fix: shortcuts while editing text item#1370
Open
letsfindaway wants to merge 1 commit intoOpenBoard-org:devfrom
Open
fix: shortcuts while editing text item#1370letsfindaway wants to merge 1 commit intoOpenBoard-org:devfrom
letsfindaway wants to merge 1 commit intoOpenBoard-org:devfrom
Conversation
Collaborator
Author
|
I reverted this PR back to "Draft" because I now think that it is better to coordinate the editing shortcuts with the focus state of the text item instead of the selection state. Only one text item can have the focus, but multiple might be selected. So I will change this. My intended target behavior is as follows:
Note that the latter should happen independent of the selection state of a web widget. The selection state shall never influence paste handling, only the focus state will. For the user, the focus state is indicated by the fact, that there is a text cursor within the text. |
ad5665b to
e5bfe4b
Compare
Collaborator
Author
|
ready for review with the above mentioned behavior implemented. |
- while editing a text item, secondary shortcuts like Shift+Ins have not been processed properly - instead they have been routed to the board controller - add UBApplication::enableEditingShortcuts to enable/disable global action shortcuts for cut/copy/paste - disable these shortcuts while a text item has focus - add missing override annotations in UBGraphicsTextItem.h Signed-off-by: letsfindaway <me@letsfindaway.de>
e5bfe4b to
69ee19d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shift+Inshave not been processed properlyUBApplication::enableEditingShortcutsto enable/disable global action shortcuts for cut/copy/pasteUBGraphicsTextItemDelegateFixes #1367