Conversation
…nhance dispose logic; update ComponentPackManager layout for better responsiveness; adjust ComponentsView variant column for improved display.
… button labels and message detail for clarity.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
… changes; implement save, discard, and cancel options for user prompts.
…s-solution into feature/components-keep-or-save-on-dispose
|
Coverage Impact ⬆️ Merging this pull request will increase total coverage on Modified Files with Diff Coverage (2)
🛟 Help
|
There was a problem hiding this comment.
Pull request overview
Adds unsaved-changes protection to the “Manage Components and Packs” webview so closing the dialog doesn’t silently drop pending edits, and includes a couple of narrow-width UI adjustments.
Changes:
- Add a modal close prompt when there are pending edits (save / don’t save / cancel-reopen) and reset cached/transient state on discard.
- Centralize current project synchronization via a getter/setter and adjust reload behavior to avoid heavy reload when the project is unchanged.
- Minor UI responsiveness tweaks (horizontal overflow wrapper; Variant column truncation intent).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
src/views/manage-components-packs/view/components/components-view.tsx |
Tweaks the Variant column configuration to support truncation/ellipsis behavior. |
src/views/manage-components-packs/view/components/component-pack-manager.tsx |
Wraps actions + views in a horizontally scrollable container for narrow layouts. |
src/views/manage-components-packs/components-packs-webview-main.ts |
Implements unsaved-changes protection on dispose, resets view state on discard, and refines reload/dirty-state behavior. |
src/views/manage-components-packs/components-packs-webview-main.test.ts |
Updates and adds unit tests for new reload logic and dispose/unsaved-changes flows. |
You can also share your feedback on Copilot code review. Take the survey.
src/views/manage-components-packs/components-packs-webview-main.ts
Outdated
Show resolved
Hide resolved
src/views/manage-components-packs/components-packs-webview-main.ts
Outdated
Show resolved
Hide resolved
src/views/manage-components-packs/components-packs-webview-main.ts
Outdated
Show resolved
Hide resolved
…s-solution into feature/components-keep-or-save-on-dispose

Fixes
This PR adds unsaved-changes protection to the Manage Components and Packs dialog.
If the dialog is closed with pending edits, users now get: Save, Don't Save or Cancel.
If there are no changes, it closes immediately.
It also improves state synchronization/reset on close and includes small UI tweaks for better narrow-width handling.
Changes
Screenshots
Checklist