Move problems processing to dedicated module

[edriouk]

Fixes

• [Refactor]: Move error processing from solution converter #146

Changes

• move diagnostic processing from solution-convertor.ts to solution-problems.ts
• make solution-convertor.ts and solution-convertor.test.ts cleanup

Checklist

• 🤖 This change is covered by unit tests (if applicable).
• 🤹 Manual testing has been performed (if necessary).
• 🛡️ Security impacts have been considered (if relevant).
• 📖 Documentation updates are complete (if required).
• 🧠 Third-party dependencies and TPIP updated (if required).

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 825edf8.

Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

[Copilot]

Pull request overview

This PR refactors solution conversion diagnostics handling by moving “Problems”/diagnostic processing out of SolutionConverterImpl into a dedicated SolutionProblemsImpl, aligning with the separation requested in #146.

Changes:

• Introduces SolutionProblemsImpl to enrich tool output and populate VS Code diagnostics on onDidConvertCompleted.
• Extends ConvertResultData to carry logMessages and optional toolsOutputMessages.
• Cleans up SolutionConverterImpl and updates/relocates unit tests accordingly.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
src/solutions/solution-problems.ts	New module responsible for enriching tool output and updating the VS Code Problems/diagnostics view.
src/solutions/solution-problems.test.ts	New unit tests covering diagnostics creation, file mapping, and west-message formatting/enrichment.
src/solutions/solution-event-hub.ts	Adds logMessages and toolsOutputMessages to ConvertResultData so downstream consumers can process diagnostics.
src/solutions/solution-event-hub.test.ts	Updates tests to include required logMessages in completion events.
src/solutions/solution-converter.ts	Removes diagnostic collection logic; now enriches tool output, computes severity, and emits enriched results via the event hub.
src/solutions/solution-converter.test.ts	Updates tests to account for diagnostics moving to SolutionProblemsImpl and asserts emitted toolsOutputMessages.
src/solutions/csolution.ts	Removes stored logMessages state from CSolution (no longer set by converter).
src/solutions/solution-manager.test.ts	Updates ConvertResultData fixture to include required logMessages.
src/desktop/extension.ts	Wires up SolutionProblemsImpl activation alongside other extension components.

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

[qltysh]

Coverage Impact

⬆️ Merging this pull request will increase total coverage on main by 0.04%.

Modified Files with Diff Coverage (2)

Rating	File	% Diff	Uncovered Line #s
	src/solutions/solution-converter.ts	100.0%
	src/solutions/solution-problems.ts	94.7%	54, 175, 187...
	Total	94.9%

🤖 Increase coverage with AI coding...

In the `solution-problems` branch, add test coverage for this new code:

- `src/solutions/solution-problems.ts` -- Lines 54, 175, 187, 285-286, and 292-302

🚦 See full report on Qlty Cloud »

🛟 Help

• Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

• Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

• File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

  • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.