Trigger restartRpc when envVars changed#160
Open
jthuangarm wants to merge 5 commits intoOpen-CMSIS-Pack:mainfrom
Open
Trigger restartRpc when envVars changed#160jthuangarm wants to merge 5 commits intoOpen-CMSIS-Pack:mainfrom
jthuangarm wants to merge 5 commits intoOpen-CMSIS-Pack:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an EnvironmentManager event to detect environment variable updates and wires it into SolutionManagerImpl so environment changes can trigger an RPC restart flow (via debounced environment-change handling), with unit tests covering the new behavior.
Changes:
- Introduces
EnvironmentManager.onDidChangeEnvVarsand fires it when the environment variable collection is updated. - Injects
EnvironmentManagerintoSolutionManagerImpland listens for env-var changes to trigger the existing debounced environment-change handling (restart RPC path). - Adds unit tests verifying the env-var change event and that a post-activation env-var change requests an RPC restart.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/solutions/solution-manager.ts | Injects EnvironmentManager and subscribes to env-var change events to trigger debounced environment change handling. |
| src/solutions/solution-manager.test.ts | Adds coverage to ensure env-var changes after activation request restartRpc. |
| src/desktop/extension.ts | Passes the existing envManager instance into SolutionManagerImpl. |
| src/desktop/env-manager.ts | Adds onDidChangeEnvVars event and fires it after updating the environment variable collection. |
| src/desktop/env-manager.test.ts | Adds tests asserting onDidChangeEnvVars fires on init and config updates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Changes
Introduce a new event to notify when environment variables change, and integrates this event into the solution management workflow, e.g. restartRpc. By doing this, restartRpc will be triggered immediately after entering environment variables in Settings and pressing the OK button.
onDidChangeEnvVarsevent to theEnvironmentManagerinterface.SolutionManagerImplto accept anEnvironmentManagerinstance and listen for the newonDidChangeEnvVarsevent, triggeringdebouncedHandleEnvironmentChangewhen environment variables are updated.Testing and Verification:
onDidChangeEnvVarsevent fires on environment initialization and configuration changes.Checklist