Skip to content

Remove --quiet for csolution convert command#574

Merged
brondani merged 1 commit intoOpen-CMSIS-Pack:mainfrom
jthuangarm:main
Mar 19, 2026
Merged

Remove --quiet for csolution convert command#574
brondani merged 1 commit intoOpen-CMSIS-Pack:mainfrom
jthuangarm:main

Conversation

@jthuangarm
Copy link
Copy Markdown
Contributor

@jthuangarm jthuangarm commented Mar 19, 2026

Fixes

Changes

  • Remove --quiet for csolution convert command from default. Observed behavior based on local test.
    The test project contains two warnings and one error message.
    • Before changes
      PS C:\Projects\TESTPROJECT> cbuild setup .\test.csolution.yml --context-set
      error csolution: conflict: component 'RteTest:CORE' is listed multiple times
      error csolution: processing context 'test1.Debug+CM0' failed
      
    • After changes
      PS C:\Projects\TESTPROJECT> cbuild setup .\test.csolution.yml --context-set
      C:/Projects/TESTPROJECT/test.csolution.yml - warning csolution: cproject.yml files should be placed in separate sub-directories
      warning csolution: 'tmpdir' does not support access sequences and must be relative to csolution.yml
      error csolution: conflict: component 'Startup' is listed multiple times
      error csolution: processing context 'test1.Debug+CM0' failed
      

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@jthuangarm
Copy link
Copy Markdown
Contributor Author

jthuangarm commented Mar 19, 2026

Question:
I noticed that the first warning includes the file path. However, errors do not, even if there are only errors existing.
Is this expected behavior, or should warning messages also not include the file path?

@jthuangarm jthuangarm requested a review from brondani March 19, 2026 12:29
Copy link
Copy Markdown
Collaborator

@brondani brondani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@brondani
Copy link
Copy Markdown
Collaborator

Question: I noticed that the first warning includes the file path. However, errors do not, even if there are only errors existing. Is this expected behavior, or should warning messages also not include the file path?

It is not related to error vs warning, but how it is reported in csolution.
Note that the ProjMgrLogger::Error and ProjMgrLogger::Warn have an optional file argument. When it is possible to know unambiguously in which file the problem is, such argument should be set.

@brondani brondani merged commit e398a7f into Open-CMSIS-Pack:main Mar 19, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants