Skip to content

TTYG-178 Split documentation from README into pages#51

Open
pgan002 wants to merge 83 commits intomainfrom
TTYG-178
Open

TTYG-178 Split documentation from README into pages#51
pgan002 wants to merge 83 commits intomainfrom
TTYG-178

Conversation

@pgan002
Copy link
Copy Markdown
Collaborator

@pgan002 pgan002 commented Feb 7, 2026

  • Move most of the documentation from the README file into separate files in a new directory docs/. Benefits:
    1. The main page (README) is shorter, and so more welcoming
    2. The main page loads faster
    3. The sections are shorter and so easier to read
    4. The directory helps to understand the contents
  • Major additions for completeness
  • Major edits clarity
  • Links to documentation sections from README and from other sections
  • Consistent section heading case: sentence case
  • Break text at 80 characters when possible

Tests

  • Spelling, grammar, typos: copy-pasted text into word processor
  • Links: manually followed each link in README.md and docs/*

TODO/questions:

  • Maybe re-join paragraphs into single long lines instead of breaking them
  • Usually, links to sections are titled "Section <full_section_name>" but in a few cases, the link title is a part of the sentence. Should we fix those?
  • Move section "Aggregate metrics" to a separate file or into section Metrics?
  • Some sections link to section with title "Inputs" but the section heading is "Input"

@pgan002 pgan002 closed this Mar 14, 2026
@pgan002 pgan002 reopened this Mar 14, 2026
@pgan002 pgan002 requested review from atagarev and nelly-hateva and removed request for atagarev and nelly-hateva March 14, 2026 02:51
@pgan002 pgan002 self-assigned this Mar 14, 2026
@pgan002 pgan002 requested a review from nelly-hateva March 30, 2026 08:09
README.md Outdated
Comment on lines +11 to +18
* [Metrics](metrics.md)
* [Installation](installation.md)
* [Usage](usage.md)
* [Configuration](documentation.md)
* [LLM use in evaluation](llm-use-in-evaluation.md)
* [Custom evaluation (custom metrics)](custom-evaluation.md)
* [Input](input.md)
* [Output](output.md)
Copy link
Copy Markdown
Collaborator

@nelly-hateva nelly-hateva Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These links don't work. If we want them to be relative, they should start with docs/. For example, docs/metrics.md. However, I think in order for the links to work on PYPI page https://pypi.org/project/graphrag-eval/ we should make them absolute, like so https://github.com/Ontotext-AD/graphrag-eval/blob/main/docs/metrics.md

Copy link
Copy Markdown
Collaborator

@nelly-hateva nelly-hateva Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also "Configuration" links to a non existing md file documentation.md, it must link to the configuration.md

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed to relative links.

Relative links are shorter to read and edit, and work in an editor and a downloaded folder.

How useful is it for the documentation to be accessible from the PyPi page?

```

To evaluate `answer_relevance` and answer correctness metrics (`answer_recall`,
`answer_precision`, `answer_f1`; see section [Output keys](output.md)) or
Copy link
Copy Markdown
Collaborator

@nelly-hateva nelly-hateva Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`answer_precision`, `answer_f1`; see section [Output keys](output.md)) or
`answer_precision`, `answer_f1) see section [Output keys](output.md) or

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This suggestion fixes the formatting, but I also suggest to link to the metrics file instead of the output and define how the metrics are calculated in the metrics file

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the suggestion? We have ( ... ; ... ).

docs/usage.md Outdated
```

`evaluation_results` is a list of statistics for each question, as in section
[Example wvaluation results](examples/output.md). The format is explained in section
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[Example wvaluation results](examples/output.md). The format is explained in section
[Example evaluation results](examples/output.md). The format is explained in section

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks. I should re-read, run a spell checker and maybe a LLM.

docs/usage.md Outdated
[Example wvaluation results](examples/output.md). The format is explained in section
[Output Keys](output.md)

# Command Line Use
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Command Line Use
## Command Line Use

Copy link
Copy Markdown
Collaborator Author

@pgan002 pgan002 Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? Should we define top-level heading "Usage" and level-2 headings "Use as a library" and "Command-line use"?

docs/usage.md Outdated
reference dataset and `actual_answer` in the target data to evaluate
1. For custom metrics:
1. Define the metrics in the [configuration file](configuration.md)
1. Include refernce and target inputs used by the metrics
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Include refernce and target inputs used by the metrics
1. Include reference and target inputs used by the metrics

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks!

docs/usage.md Outdated
Comment on lines +12 to +17
1. For `answer_relevance`, include `actual_answer` in the reference
dataset
1. For answer correctness metrics (section
[Output](output.md)), include `reference_answer` in the
reference dataset and `actual_answer` in the target data to evaluate
1. For custom metrics:
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is inconsistent, for the answer relevance and for the custom metrics we don't link to the definition, but for answer correctness we do. Also, I would define the metrics (except for the custom metrics) in the metrics file, and link to it.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added links and made other changes to this section. Linked to metrics here.

As for changes to the contents of metrics.md in comments to that file.

@pgan002 pgan002 requested a review from nelly-hateva March 30, 2026 23:33
@pgan002
Copy link
Copy Markdown
Collaborator Author

pgan002 commented Mar 30, 2026

@nelly-hateva please close threads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants