chore: automate sqlite driver selection via build tags (#805)#806
Open
tejasva-vardhan wants to merge 1 commit intoOneBusAway:mainfrom
Open
chore: automate sqlite driver selection via build tags (#805)#806tejasva-vardhan wants to merge 1 commit intoOneBusAway:mainfrom
tejasva-vardhan wants to merge 1 commit intoOneBusAway:mainfrom
Conversation
Contributor
Author
|
@aaronbrethorst |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR automates the SQLite driver selection for Maglev using Go build tags, directly addressing and resolving #805. It removes the friction for Windows developers who previously had to manually pass the
-tags puregoflag to build or run the project.Changes Made
driver_pure.go: Uses the//go:build windows && !cgotag to automatically loadmodernc.org/sqliteon Windows machines without CGO.driver_cgo.go: Uses the//go:build !windows || cgotag to preserve the high-performancemattn/go-sqlite3driver for Linux/macOS and explicit CGO builds.go.modandgo.sumcorrectly track both drivers.helpers.go) Refactoring: Replaced hardcoded"sqlite3"/"sqlite"strings with a cross-platformDriverNameconstant.Verification
go run ./cmd/apiworks out-of-the-box without GCC/MinGW toolchains.Closes #805