fix: propagate ctx to gtfstidy subprocess#802
Open
ashnaaseth2325-oss wants to merge 1 commit intoOneBusAway:mainfrom
Open
fix: propagate ctx to gtfstidy subprocess#802ashnaaseth2325-oss wants to merge 1 commit intoOneBusAway:mainfrom
ashnaaseth2325-oss wants to merge 1 commit intoOneBusAway:mainfrom
Conversation
Use exec.CommandContext so the gtfstidy process is killed when the caller's context is cancelled or times out, preventing graceful shutdown from blocking indefinitely. Signed-off-by: ashnaaseth2325-oss <ashnaaseth2325@gmail.com>
Contributor
Author
|
Hi @aaronbrethorst |
Contributor
Author
|
Hello @aaronbrethorst |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes a context propagation issue in the GTFS tidy pipeline where subprocesses could not be canceled, leading to hangs during shutdown or timeout. It updates
tidyGTFSDatato accept acontext.Contextand usesexec.CommandContextinstead ofexec.Command.Primary changes are in
internal/gtfs/tidy.go, with call-site updates ininternal/gtfs/static.goand test adjustments ininternal/gtfs/tidy_test.go.FIX
VERIFICATION
Tested by enabling GTFS tidy, triggering a feed update, and sending a SIGTERM while the tidy process was running. The service now shuts down cleanly without hanging, and the subprocess exits immediately on cancellation. Builds and existing tests pass with no regressions.