Fix/schedule for route trip ref ids#758
Open
ashnaaseth2325-oss wants to merge 6 commits intoOneBusAway:mainfrom
Open
Fix/schedule for route trip ref ids#758ashnaaseth2325-oss wants to merge 6 commits intoOneBusAway:mainfrom
ashnaaseth2325-oss wants to merge 6 commits intoOneBusAway:mainfrom
Conversation
Use comma-ok on presentRoutes to skip trips whose route ID is not populated, preventing silent empty AgencyID in combined IDs. Signed-off-by: ashnaaseth2325-oss <ashnaaseth2325@gmail.com>
Signed-off-by: ashnaaseth2325-oss <ashnaaseth2325@gmail.com>
… trip refs Signed-off-by: ashnaaseth2325-oss <ashnaaseth2325@gmail.com>
…leWithNilID test Signed-off-by: ashnaaseth2325-oss <ashnaaseth2325@gmail.com>
Contributor
Author
|
Hi @aaronbrethorst, |
Contributor
Author
|
Hi @aaronbrethorst, just a quick ping on this PR . |
Contributor
Author
|
Hi @aaronbrethorst, |
Member
|
please fix merge conflicts! |
Contributor
Author
|
Thanks @aaronbrethorst ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. SUMMARY
Fixes missing agency prefixes on
routeIdandserviceIdin theschedule-for-routeresponse.Small change inschedule_for_route_handler.goto make output consistent with other endpoints.2. FIX
3. VERIFICATION
Call
/schedule-for-route/1_routeXCheck IDs:
"routeX""1_routeX"Follow-up calls using these IDs now work (no 404)