Fix/block sequence fallback#757
Open
ashnaaseth2325-oss wants to merge 4 commits intoOneBusAway:mainfrom
Open
Conversation
Signed-off-by: ashnaaseth2325-oss <ashnaaseth2325@gmail.com>
ashnaaseth2325-oss
force-pushed
the
fix/block-sequence-fallback
branch
from
03cb01c to
71b74ef
Compare
Signed-off-by: ashnaaseth2325-oss <ashnaaseth2325@gmail.com>
Add MockClearServiceIDsCache() before and after the plural arrivals endpoint call in TestArrivalsAndDeparturesForStopHandler_MultiAgency_Regression, following the same pattern established in setupDelayPropTestData and TestArrivalsAndDeparturesForStop_VehicleWithNilID. This prevents a stale cache entry for "20100101" from hiding the newly inserted "service1" calendar when tests share the same GtfsManager instance. Signed-off-by: ashnaaseth2325-oss <ashnaaseth2325@gmail.com>
Contributor
Author
|
Hi @aaronbrethorst , |
Contributor
Author
|
Hi @aaronbrethorst, just checking in on this PR. Happy to make any changes if needed. Thanks! |
Contributor
Author
|
Hi @aaronbrethorst, |
Member
|
@ashnaaseth2325-oss please fix merge conflicts! |
1 similar comment
Member
|
@ashnaaseth2325-oss please fix merge conflicts! |
Contributor
Author
|
Thanks for pointing this out @aaronbrethorst ! |
Contributor
Author
|
Hi @aaronbrethorst |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. SUMMARY
Fixes a bug where the function returned
0on DB error instead of the givenstopSequence.Keeps fallback behavior consistent.
2. FIX
3. VERIFICATION
Result: returns
stopSequence(not0)