Skip to content

Fix rlp: expected List error for legacy Arbitrum receipt encoding#4469

Merged
eljobe merged 2 commits intomasterfrom
fix-legacy-receipt-rlp-decoding-master
Mar 6, 2026
Merged

Fix rlp: expected List error for legacy Arbitrum receipt encoding#4469
eljobe merged 2 commits intomasterfrom
fix-legacy-receipt-rlp-decoding-master

Conversation

@joshuacolvin0
Copy link
Member

part of NIT-4600
pulls in OffchainLabs/go-ethereum#634

Update go-ethereum submodule with fix for ReadCanonicalRawReceipt
failing on blocks with Arbitrum legacy receipt encoding.

When NewListIterator or extractReceiptFields fails on legacy formats,
fall back to ReadRawReceipts which handles both modern and legacy
receipt formats via ReceiptForStorage.DecodeRLP.

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com

Update go-ethereum submodule with fix for ReadCanonicalRawReceipt
failing on blocks with Arbitrum legacy receipt encoding.

When NewListIterator or extractReceiptFields fails on legacy formats,
fall back to ReadRawReceipts which handles both modern and legacy
receipt formats via ReceiptForStorage.DecodeRLP.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@joshuacolvin0 joshuacolvin0 force-pushed the fix-legacy-receipt-rlp-decoding-master branch from d608d69 to 24a2b76 Compare March 5, 2026 05:37
@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 32.77%. Comparing base (dc92bdf) to head (d18c38b).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4469      +/-   ##
==========================================
- Coverage   32.90%   32.77%   -0.13%     
==========================================
  Files         493      493              
  Lines       58295    58295              
==========================================
- Hits        19182    19108      -74     
- Misses      35782    35840      +58     
- Partials     3331     3347      +16     

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

❌ 8 Tests Failed:

Tests completed Failed Passed Skipped
4244 8 4236 0
View the top 3 failed tests by shortest run time
TestNitroNodeVersionAlerter
Stack Traces | 0.990s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [03-06|09:59:17.933] Deploying ospHostIo
INFO [03-06|09:59:17.933] Updated payload                          id=0x0330065e2dda5b32 number=23  hash=35e8e9..26513a txs=1   withdrawals=0 gas=5,156,618  fees=5.156618e-06   root=95d27f..080647 elapsed=2.341ms
INFO [03-06|09:59:17.934] Stopping work on payload                 id=0x0378d3bbf677a02f reason=delivery
INFO [03-06|09:59:17.934] Starting work on payload                 id=0x03280e9e16b9db27
INFO [03-06|09:59:17.938] Updated payload                          id=0x03280e9e16b9db27 number=58  hash=fd3c6e..0b2c46 txs=1   withdrawals=0 gas=21000      fees=0.00209840565  root=554c44..fc8f0f elapsed=3.323ms
INFO [03-06|09:59:17.932] Submitted transaction                    hash=0x7d2156a53729d4bab745be126d970760abf1e4fd0d93a9d6422674a49e308d9a from=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A nonce=25  recipient=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A value=1
INFO [03-06|09:59:17.940] Deploying validator wallet creator contract
INFO [03-06|09:59:17.941] Stopping work on payload                 id=0x03280e9e16b9db27 reason=delivery
INFO [03-06|09:59:17.942] Submitted transaction                    hash=0x49cb09e59e00238da9aa4594981aa8fec3f03ec39e084f84a2cae834dfaaf034 from=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A nonce=1   recipient=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A value=1,000,000,000,000
INFO [03-06|09:59:17.943] Submitted contract creation              hash=0x4882f620b2250e5d8ef066969eee44478b10498740fd774086927102ea74b7d8 from=0x57Ff0F473737a1c161bfF9efDF016F7991585088 nonce=16  contract=0xffd0c2C95214aa9980D7419bd87c260C80Ce2546 value=0
INFO [03-06|09:59:17.943] Deploying ospEntry
INFO [03-06|09:59:17.945] Submitted contract creation              hash=0xaafef10e37d7cfc2c7b0029643a8a350707536e8f8ca9b8b8b59c0dbf2b8e7b5 from=0x57Ff0F473737a1c161bfF9efDF016F7991585088 nonce=18  contract=0x548c9E48e32748F36CD0265E6e6359e20c2432FA value=0
INFO [03-06|09:59:17.947] Starting work on payload                 id=0x037bb5b3dcbe3731
INFO [03-06|09:59:17.950] Updated payload                          id=0x037bb5b3dcbe3731 number=36  hash=02b8bc..38365e txs=1   withdrawals=0 gas=21000      fees=0.002069773231 root=6ea9bb..27eb77 elapsed=2.715ms
INFO [03-06|09:59:17.951] Deploying admin logic contracts
INFO [03-06|09:59:17.952] Imported new potential chain segment     number=27  hash=7031e5..282e76 blocks=1  txs=1   mgas=0.050  elapsed=19.569ms     mgasps=2.558    triediffs=134.56KiB triedirty=0.00B
INFO [03-06|09:59:17.952] Chain head was updated                   number=27  hash=7031e5..282e76 root=9b2f2e..16456e elapsed="118.6µs"
INFO [03-06|09:59:17.953] Stopping work on payload                 id=0x037bb5b3dcbe3731 reason=delivery
INFO [03-06|09:59:17.953] Starting work on payload                 id=0x03f45c128ce57b5a
--- FAIL: TestNitroNodeVersionAlerter (0.99s)
TestVersion30
Stack Traces | 5.430s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:67 +0x798
        testing.tRunner(0xc0516e6fc0, 0x3d28898)
        	/opt/hostedtoolcache/go/1.25.7/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.7/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:94: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
INFO [03-06|09:57:40.552] Submitted contract creation              hash=0x0217f2d489f3e0b48a3e2e39d80eb68aba6ab610a5458fe0ff7cca538e3f7c15 from=0x57Ff0F473737a1c161bfF9efDF016F7991585088 nonce=10  contract=0xd8Ef51E29965b7c1388c0BFD630D4cFc46D661b5 value=0
INFO [03-06|09:57:40.553] Stopping work on payload                 id=0x036923433e5f7e45 reason=delivery
INFO [03-06|09:57:40.551] Starting peer-to-peer node               instance=test-stack-name/linux-amd64/go1.25.7
WARN [03-06|09:57:40.553] P2P server will be useless, neither dialing nor listening
INFO [03-06|09:57:40.553] Submitted transaction                    hash=0x67349de5b4b4679fd36f24ed30b204a55d4ad74c4fbd39d019d1f669c2afa1ce from=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A nonce=580 recipient=0x7E23C8862920797d81916d62c274dd9217113e28 value=1,000,000,000,000
INFO [03-06|09:57:40.553] InboxTracker                             sequencerBatchCount=4  messageCount=7   l1Block=31  l1Timestamp=2026-03-06T09:57:40+0000
INFO [03-06|09:57:40.554] Starting work on payload                 id=0x037dc632c17aabfe
INFO [03-06|09:57:40.554] Updated payload                          id=0x037dc632c17aabfe number=8   hash=853593..495fe1 txs=1  withdrawals=0 gas=1,491,086  fees=1.491086e-06   root=1574c1..3ef981 elapsed="622.932µs"
INFO [03-06|09:57:40.554] Imported new potential chain segment     number=10  hash=3eb265..b35adf blocks=1  txs=1  mgas=2.308  elapsed=3.304ms      mgasps=698.470  triediffs=31.56KiB  triedirty=0.00B
INFO [03-06|09:57:40.555] Chain head was updated                   number=10  hash=3eb265..b35adf root=1cbba2..33437b elapsed="261.588µs"
INFO [03-06|09:57:40.555] Stopping work on payload                 id=0x037dc632c17aabfe reason=delivery
WARN [03-06|09:57:40.555] Served eth_call                          reqid=11  duration=5.142865715s  err="execution aborted (timeout = 5s)"
--- FAIL: TestVersion30 (5.43s)
TestVersion40
Stack Traces | 5.820s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
    precompile_inclusion_test.go:94: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
INFO [03-06|09:57:40.556] Imported new potential chain segment     number=8   hash=853593..495fe1 blocks=1  txs=1  mgas=1.491  elapsed=1.364ms      mgasps=1092.725 triediffs=25.01KiB  triedirty=0.00B
INFO [03-06|09:57:40.556] Updated payload                          id=0x03d0c9fa8d66f7d2 number=115 hash=10da8c..bf59ea txs=1  withdrawals=0 gas=21000      fees=0.002099999116 root=a6df7d..553a4d elapsed=4.161ms
INFO [03-06|09:57:40.556] Chain head was updated                   number=8   hash=853593..495fe1 root=1574c1..3ef981 elapsed="245.869µs"
INFO [03-06|09:57:40.556] Writing cached state to disk             block=1   hash=226455..7a90e1 root=8448b4..050cee
INFO [03-06|09:57:40.557] Persisted trie from memory database      nodes=20   flushnodes=0 size=3.26KiB   flushsize=0.00B time="118.561µs" flushtime=0s gcnodes=0 gcsize=0.00B gctime="1.763µs"   livenodes=0    livesize=0.00B
INFO [03-06|09:57:40.557] Writing cached state to disk             block=1   hash=226455..7a90e1 root=8448b4..050cee
INFO [03-06|09:57:40.557] Persisted trie from memory database      nodes=0    flushnodes=0 size=0.00B     flushsize=0.00B time="1.563µs"   flushtime=0s gcnodes=0 gcsize=0.00B gctime=0s          livenodes=0    livesize=0.00B
INFO [03-06|09:57:40.557] Writing snapshot state to disk           root=6b754c..7398ca
INFO [03-06|09:57:40.557] Persisted trie from memory database      nodes=0    flushnodes=0 size=0.00B     flushsize=0.00B time="1.222µs"   flushtime=0s gcnodes=0 gcsize=0.00B gctime=0s          livenodes=0    livesize=0.00B
INFO [03-06|09:57:40.557] Blockchain stopped
INFO [03-06|09:57:40.557] Submitted contract creation              hash=0xf39fb3d1c8ea790e759b985d337110ba1e7431cf38cba286758fbcb44d9049b2 from=0x57Ff0F473737a1c161bfF9efDF016F7991585088 nonce=11  contract=0x112022E83AaD0dC3a1a61312b19c2F68A43ed17f value=0
INFO [03-06|09:57:40.557] Stopping work on payload                 id=0x03d0c9fa8d66f7d2 reason=delivery
INFO [03-06|09:57:40.557] InboxTracker                             sequencerBatchCount=80 messageCount=898 l1Block=105 l1Timestamp=2026-03-06T09:57:40+0000
INFO [03-06|09:57:40.558] Deploying bridge creator itself
INFO [03-06|09:57:40.558] Imported new potential chain segment     number=115 hash=10da8c..bf59ea blocks=1  txs=1  mgas=0.021  elapsed=1.561ms      mgasps=13.451   triediffs=588.15KiB triedirty=0.00B
INFO [03-06|09:57:40.558] Chain head was updated                   number=115 hash=10da8c..bf59ea root=a6df7d..553a4d elapsed="59.551µs"
INFO [03-06|09:57:40.558] Starting work on payload                 id=0x03aab90de2a4479a
INFO [03-06|09:57:40.559] Submitted contract creation              hash=0xf3ab169959ed3a8a63a941f2f2cf30f4a21ac55cfee441f14fed03af6f9150ce from=0x57Ff0F473737a1c161bfF9efDF016F7991585088 nonce=7   contract=0x6Fe8F13052e9d166cf09a37fb089C5c9bdc1B080 value=0
--- FAIL: TestVersion40 (5.82s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

joshuacolvin0 added a commit that referenced this pull request Mar 5, 2026
…oding

Port - Fix rlp: expected List error for legacy Arbitrum receipt encoding (#4469)
@eljobe eljobe enabled auto-merge March 6, 2026 09:43
@eljobe eljobe added this pull request to the merge queue Mar 6, 2026
Merged via the queue into master with commit 1bcfb96 Mar 6, 2026
27 checks passed
@eljobe eljobe deleted the fix-legacy-receipt-rlp-decoding-master branch March 6, 2026 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants