fix: enforce request size limits for uploads#43
Open
Aaravanand00 wants to merge 3 commits intoOSeMOSYS:masterfrom
Open
fix: enforce request size limits for uploads#43Aaravanand00 wants to merge 3 commits intoOSeMOSYS:masterfrom
Aaravanand00 wants to merge 3 commits intoOSeMOSYS:masterfrom
Conversation
Author
|
Hi @VedranKapor , I worked on this issue by introducing request size protections to prevent unbounded uploads in the Flask backend. Approach The application currently sets Testing I tested the changes locally by:
While testing on Windows, I also adjusted the ZIP deletion logic to avoid file locking when rejecting oversized archives. Overall, the goal was to add reasonable protections while keeping the existing API behavior unchanged. Happy to adjust anything if you prefer a different approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #40
This PR introduces request size protections to prevent unbounded file uploads in the Flask backend.
Changes
MAX_CONTENT_LENGTHwith a default limit of 500 MBUPLOAD_MAX_SIZESecurity & Stability Improvements
Configuration
The upload size limit can be overridden using:
If not provided, the default limit of 500 MB is used.
No breaking API changes were introduced.