Skip to content

Fix parsing of a key-like value at end of entry #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
smarr wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix parsing of a key-like value at end of entry #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b43779
Added test with `year = 2020` at end of entry
smarr May 16, 2020
5181b49
Use trim() to make value compatible with regex
smarr May 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bibtexParse.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@
} else if (this.tryMatch('"')) {
return this.value_quotes();
} else {
var k = this.key();
var k = this.key().trim();
if (k.match("^[0-9]+$"))
return k;
else if (this.months.indexOf(k.toLowerCase()) >= 0)
Expand Down
28 changes: 28 additions & 0 deletions test/proceedings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
import test from 'ava';

const bibtexParse = require('../bibtexParse');

const input = `@proceedings{Last:2020:P20I3,
doi = {10.22152/programming-journal.org/2020/4/issue3},
editor = {Last, First},
month = {February},
publisher = {AOSA Inc.},
title = {The Art, Science, and Engineering of Programming},
url = {https://programming-journal.org/2020/4/issue3/},
volume = 4,
year = 2020
}`

const output = [ { citationKey: 'Last:2020:P20I3',
entryType: 'proceedings',
entryTags:
{ title: 'The Art, Science, and Engineering of Programming',
year: '2020',
month: 'February',
editor: 'Last, First',
publisher: 'AOSA Inc.',
volume: '4',
doi: '10.22152/programming-journal.org/2020/4/issue3',
url: 'https://programming-journal.org/2020/4/issue3/' } } ]

test('proceedings should parse', t => t.deepEqual(output, bibtexParse.toJSON(input)));