Modify to fix issue for #2076, Containment expand problem#2083
Open
xuzhg wants to merge 1 commit intoOData:masterfrom
Open
Modify to fix issue for #2076, Containment expand problem#2083xuzhg wants to merge 1 commit intoOData:masterfrom
xuzhg wants to merge 1 commit intoOData:masterfrom
Conversation
xuzhg
force-pushed
the
issue2076ExpandOnNavigation
branch
from
6667e20 to
7f03890
Compare
mikepizzo
reviewed
Jan 5, 2021
|
|
||
| namespace AspNetCore3xEndpointSample.Web.Controllers | ||
| { | ||
| {/* |
Contributor
There was a problem hiding this comment.
Is there a reason to keep the commented out version?
mikepizzo
reviewed
Jan 5, 2021
|
|
||
| namespace AspNetCore3xEndpointSample.Web.Models | ||
| { | ||
| {/* |
Contributor
There was a problem hiding this comment.
why is this commented out? Is it no longer used? Just remove?
mikepizzo
reviewed
Jan 5, 2021
| //public CustomerOrderContext(DbContextOptions<CustomerOrderContext> options) | ||
| // : base(options) | ||
| //{ | ||
| //} |
mikepizzo
reviewed
Jan 5, 2021
| public DbSet<Customer> Customers { get; set; } | ||
|
|
||
| public DbSet<Order> Orders { get; set; } | ||
| // public DbSet<Order> Orders { get; set; } |
mikepizzo
reviewed
Jan 5, 2021
| builder.EntitySet<Order>("Orders"); | ||
| var customers = builder.EntitySet<Customer>("Customers"); | ||
| customers.Binding.HasManyPath(c => c.CustomerReferrals, true).HasRequiredBinding(r => r.ReferredCustomer, "Customers"); | ||
| // builder.EntitySet<Order>("Orders"); |
mikepizzo
reviewed
Jan 5, 2021
| services.AddDbContext<CustomerOrderContext>(opt => opt.UseLazyLoadingProxies().UseInMemoryDatabase("CustomerOrderList")); | ||
| //services.AddDbContext<CustomerOrderContext>(opt => opt.UseLazyLoadingProxies().UseInMemoryDatabase("CustomerOrderList")); | ||
| //services.AddScoped<CustomerOrderContext>(_ => new CustomerOrderContext(Configuration.GetConnectionString("DefaultConnection"))); | ||
| services.AddOData(); |
Contributor
There was a problem hiding this comment.
Remove commented out lines?
Contributor
|
Is there a test to verify that the issue reported in issue 2076 is addressed? I see changes to the sample but no code that calls them in new ways. |
Contributor
|
Hey @xuzhg -- Do you have an update on this PR? I left a few minor comments. Can we address, rebase, and merge, or are there open issues? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
This pull request fixes issue #2076.
Description
*This fixes the issue in #2076.
2)ODataQueryOptionParser should know the "Path" to parse the query option.
Checklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.