[16.0][FW] stock_picking_batch_creation: multiple ports from 18.0#1141
Open
[16.0][FW] stock_picking_batch_creation: multiple ports from 18.0#1141
Conversation
Make it easier to pass custom vals for the created product.
When trying to create a batch picking only with the first availale transfer, there could be some occurence where that picking does not fit the dimension of the device and can not be split. This can happen when all moves from the transfer are oversize compare to the dimension of the device. After this change, the module will use the next transfer to create a batch until it is successfull.
Before this change when searching for a device to use for the batch, the order of the devices was not guaranteed although important. And it could cause some batch split not happening. Now the possible devices will be sorted by their default order, which is by sequence and name.
In case device has no attribute max_weight set, _init_counters function will set self._remaining_weight as None, so we need to consider this possibility before decreasing it when adding picking.
Allow no max nbr lines Allow no max volume Add test
5a5b44d to
58bf3b5
Compare
As specific exceptions inherit from UserError, there is no need to do such change.
504a48d to
16c7640
Compare
de5c436 to
02399f9
Compare
Author
rousseldenis
approved these changes
Mar 12, 2026
jbaudoux
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Port from 18.0 to 16.0:
stock_picking_batch_creation: Allows to split picking stock-logistics-workflow#2075