[FIX] shopfloor_base: Set _menu and _profile as properties#1115
[FIX] shopfloor_base: Set _menu and _profile as properties#1115rousseldenis wants to merge 1 commit intoOCA:16.0from
Conversation
As soon as work context is not loaded yet at service init(), change them to properties to allow dynamic evaluation.
simahawk
left a comment
There was a problem hiding this comment.
I'm not sure to understand what you are trying to fix 🤔
What's the use case?
I think I did that on purpose to freeze the two variables at component instance level.
See acsone@9dfe2ab
Personally, I needed this while debugging #1085. I had the same problem that described here: the variables where not populated when I called them. |
|
This PR has the |
1 similar comment
|
This PR has the |
Debugging what and how? If you lookup the component using component machinery, if the work context used it's properly set before the component is initialized I see no reason to no have the value propagated. If you had this issue only on tests and not while using the app, then you might have something wrong in the tests. |
That's the case in production with real behavior. The values are void But why should not menu and profiles can be evaluated at runtime ? |
As soon as work context is not loaded yet at service init(), change them to properties to allow dynamic evaluation.