Skip to content

[FIX] shopfloor_base: Set _menu and _profile as properties#1115

Open
rousseldenis wants to merge 1 commit intoOCA:16.0from
acsone:16.0-fix-shopfloor-menu-dro
Open

[FIX] shopfloor_base: Set _menu and _profile as properties#1115
rousseldenis wants to merge 1 commit intoOCA:16.0from
acsone:16.0-fix-shopfloor-menu-dro

Conversation

@rousseldenis
Copy link

As soon as work context is not loaded yet at service init(), change them to properties to allow dynamic evaluation.

As soon as work context is not loaded yet at service init(), change them
to properties to allow dynamic evaluation.
@OCA-git-bot
Copy link
Contributor

Hi @simahawk, @guewen, @sebalix,
some modules you are maintaining are being modified, check this out!

Copy link

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure to understand what you are trying to fix 🤔
What's the use case?

I think I did that on purpose to freeze the two variables at component instance level.
See acsone@9dfe2ab

@nicolas-delbovier-acsone

I'm not sure to understand what you are trying to fix 🤔 What's the use case?

I think I did that on purpose to freeze the two variables at component instance level. See acsone@9dfe2ab

Personally, I needed this while debugging #1085. I had the same problem that described here: the variables where not populated when I called them.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

1 similar comment
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@simahawk
Copy link

simahawk commented Feb 6, 2026

I'm not sure to understand what you are trying to fix 🤔 What's the use case?
I think I did that on purpose to freeze the two variables at component instance level. See acsone@9dfe2ab

Personally, I needed this while debugging #1085. I had the same problem that described here: the variables where not populated when I called them.

Debugging what and how? If you lookup the component using component machinery, if the work context used it's properly set before the component is initialized I see no reason to no have the value propagated.

If you had this issue only on tests and not while using the app, then you might have something wrong in the tests.
I'll check on that PR.

@rousseldenis
Copy link
Author

I see no reason to no have the value propagated.

That's the case in production with real behavior. The values are void

But why should not menu and profiles can be evaluated at runtime ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants