Skip to content

[18.0][ADD] webservice_server_env: make server_environment an optional dependency#101

Open
dreispt wants to merge 2 commits intoOCA:18.0from
ursais:18-dr-webservice_server_env
Open

[18.0][ADD] webservice_server_env: make server_environment an optional dependency#101
dreispt wants to merge 2 commits intoOCA:18.0from
ursais:18-dr-webservice_server_env

Conversation

@dreispt
Copy link
Member

@dreispt dreispt commented Jun 15, 2025 •
edited
Loading

Forward port of #42

  • [REF] webservice: server_environment should not be a required dependency
  • [ADD] webservice_server_env: make server_environment an optional dependency

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Jun 15, 2025

Hi @etobella,
some modules you are maintaining are being modified, check this out!

@dreispt dreispt force-pushed the 18-dr-webservice_server_env branch 2 times, most recently from 62ea7a3 to 5ccd5f6 Compare June 15, 2025 14:09
@dreispt dreispt force-pushed the 18-dr-webservice_server_env branch from 5ccd5f6 to 04908b5 Compare June 15, 2025 14:13
@dreispt dreispt mentioned this pull request Jun 15, 2025
Open
@github-actions
Copy link

github-actions bot commented Oct 19, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 19, 2025
@dreispt dreispt removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 19, 2025
@dreispt
Copy link
Member Author

dreispt commented Oct 19, 2025

Any reason to hold this back?

@github-actions
Copy link

github-actions bot commented Feb 22, 2026

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 22, 2026
@simahawk simahawk mentioned this pull request Mar 4, 2026
Open
@simahawk
Copy link
Contributor

simahawk commented Mar 4, 2026

Any reason to hold this back?

Just time to review it and test it on real life project 😅
Also this is perfectly in line w/ this roadmap OCA/server-env#258

simahawk
simahawk reviewed Mar 4, 2026
View reviewed changes
setup/webservice_server_env/odoo/addons/webservice_server_env
@@ -0,0 +1 @@
../../../../webservice_server_env No newline at end of file
Copy link
Contributor

@simahawk simahawk Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setup folder is a leftover from the porting ;)

Copy link
Member Author

@dreispt dreispt Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to take over and make a superseding PR, since you are working on this right now?

Copy link
Contributor

@simahawk simahawk Mar 4, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not working on it. Here you should just exclude the setup folder from the cherry-pick 😉

simahawk
simahawk approved these changes Mar 4, 2026
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, mere code review, no test

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 8, 2026
@yankinmax
Copy link

yankinmax commented Mar 23, 2026

Hello @dreispt
We're going to push some effort to remove server_environment dependency on other storage modules as well.
Can you pls refresh this PR?
From my side I'll also take a chance to get more reviews so it can be merged very soon.

ivantodorovich
ivantodorovich approved these changes Mar 23, 2026
View reviewed changes
Copy link

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

ivantodorovich
ivantodorovich reviewed Mar 23, 2026
View reviewed changes
webservice_server_env/__manifest__.py
"author": "Creu Blanca, Camptocamp, Odoo Community Association (OCA)",
"website": "https://github.com/OCA/web-api",
"depends": ["webservice", "server_environment"],
"auto_install": True,
Copy link

@ivantodorovich ivantodorovich Mar 23, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dreispt

Will it get automatically installed on deployments that currently have webservice installed and only get an update on this module?

Or do we need a migration script for this?

Honest question. Not sure how Odoo handles that -- but I believe we should not alter the behavior for already running instances

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simahawk simahawk simahawk approved these changes

+2 more reviewers

@ivantodorovich ivantodorovich ivantodorovich approved these changes

@yankinmax yankinmax yankinmax approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dreispt @OCA-git-bot @simahawk @yankinmax @ivantodorovich