Skip to content

[18.0][ADD] maintenance_helpdesk_mgmt: New module#547

Merged
OCA-git-bot merged 1 commit intoOCA:18.0from
Tecnativa:18.0-add-maintenance_request_helpdesk_ticket_
Mar 20, 2026
Merged

[18.0][ADD] maintenance_helpdesk_mgmt: New module#547
OCA-git-bot merged 1 commit intoOCA:18.0from
Tecnativa:18.0-add-maintenance_request_helpdesk_ticket_

Conversation

@christian-ramos-tecnativa
Copy link
Contributor

New module to link maintenance requests with helpdesk tickets

@Tecnativa TT61468
@pedrobaeza @cristina-hidalgo-tecnativa

@pedrobaeza
Copy link
Member

pedrobaeza commented Mar 19, 2026

Better to call it maintenance_helpdesk_mgmt, or it should be helpdesk_mgmt_maintenance and go to OCA/helpdesk. Which part is the "most important"?

@pedrobaeza pedrobaeza added this to the 18.0 milestone Mar 19, 2026
@christian-ramos-tecnativa
Copy link
Contributor Author

The link is only available from the maintenance view so it should be the "most important" part, will rename the module

@christian-ramos-tecnativa christian-ramos-tecnativa force-pushed the 18.0-add-maintenance_request_helpdesk_ticket_ branch from fbd3f0a to 2014f7b Compare March 19, 2026 12:49
@christian-ramos-tecnativa christian-ramos-tecnativa changed the title [18.0][ADD] maintenance_request_helpdesk_ticket: New module [18.0][ADD] maintenance_request_helpdesk: New module Mar 19, 2026
@christian-ramos-tecnativa christian-ramos-tecnativa force-pushed the 18.0-add-maintenance_request_helpdesk_ticket_ branch from 2014f7b to 39aaced Compare March 19, 2026 12:54
@christian-ramos-tecnativa christian-ramos-tecnativa changed the title [18.0][ADD] maintenance_request_helpdesk: New module [18.0][ADD] maintenance_helpdesk: New module Mar 19, 2026
@christian-ramos-tecnativa christian-ramos-tecnativa force-pushed the 18.0-add-maintenance_request_helpdesk_ticket_ branch 2 times, most recently from 5ee0f21 to 0886e3f Compare March 19, 2026 15:18
@christian-ramos-tecnativa christian-ramos-tecnativa changed the title [18.0][ADD] maintenance_helpdesk: New module [18.0][ADD] maintenance_helpdesk_mgmt: New module Mar 19, 2026
@christian-ramos-tecnativa
Copy link
Contributor Author

Name changed

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I miss some usage instructions.

@christian-ramos-tecnativa christian-ramos-tecnativa force-pushed the 18.0-add-maintenance_request_helpdesk_ticket_ branch from 0886e3f to 75ebaeb Compare March 20, 2026 09:54
@christian-ramos-tecnativa
Copy link
Contributor Author

Done! Thanks for the review

Copy link

@david-banon-tecnativa david-banon-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review OK

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-547-by-pedrobaeza-bump-nobump, awaiting test results.

Copy link
Contributor

@dalonsod dalonsod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only code review

<field name="inherit_id" ref="maintenance.hr_equipment_request_view_form" />
<field name="arch" type="xml">
<notebook position="inside">
<page name="helpdesk_tickets" string="Helpdesk Tickets">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only helpdesk users should access it

@@ -0,0 +1,27 @@
<!-- Copyright 2026 Tecnativa - Christian Ramos
License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). -->
<odoo>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be interesting adding request count and link to them from kanban view, what do you think? And maybe a filter for "with maintenance requests" tickets

<!-- Copyright 2026 Tecnativa - Christian Ramos
License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). -->
<odoo>
<record model="ir.ui.view" id="hr_equipment_request_view_form_button_box">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar than tickets, should you consider some stuff that show ticket information related to requests at kanban and search views?

@OCA-git-bot OCA-git-bot merged commit bba7f7a into OCA:18.0 Mar 20, 2026
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 56132c4. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 18.0-add-maintenance_request_helpdesk_ticket_ branch March 20, 2026 11:38
@pedrobaeza
Copy link
Member

Ouch, too late... @christian-ramos-tecnativa please do a follow-up PR with David's comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants