[14.0][MIG] maintenance_stock: Migration to 14.0 by Reyes4711-S73 · Pull Request #347 · OCA/maintenance

Reyes4711-S73 · 2023-07-06T06:24:06Z

Standard migration to 14.0

dalonsod · 2023-07-06T06:28:54Z

Hello @Reyes4711-S73 your PR is based on #337 , isn't it?

Please check, because that PR has new adjustments since you've cloned it

Reyes4711-S73 · 2023-07-06T06:42:50Z

@dalonsod I added your last changes in my migration PR

dalonsod · 2023-07-06T17:05:15Z

Please check errors in tests

mamcode · 2023-07-09T18:07:40Z

maintenance_stock/data/demo_maintenance_stock.xml

+        </function>
+        <function model="stock.inventory" name="action_validate">
+            <function
+                eval="[[('state','=','draft'),('id', '=', ref('maintenance_stock.stock_inventory_toner'))]]"


The inventory for demo product is In Progress when installing the module:

Perhaps it is this line that does not allow validating the inventory. Maybe the state at this moment is confirm (not tested).

Suggested change

eval="[[('state','=','draft'),('id', '=', ref('maintenance_stock.stock_inventory_toner'))]]"

eval="[[('state','=','confirm'),('id', '=', ref('maintenance_stock.stock_inventory_toner'))]]"

Can you review please ?

dalonsod · 2023-07-11T18:13:11Z

@Reyes4711-S73 I've still found some issues in commit history:

Your migration commit has some changes that are already made in current v13 migration commit. That's because you your commit history is still created from an old version. Please check.
Pre-commit stuff commit has adjustments in test file that shouldn't belong to that commit. If fix in tests are needed, please place them in migration commit.

Reyes4711-S73 · 2023-08-16T08:22:38Z

@mamcode @dalonsod I added the merged commit and solved some issues. Please, review it

mamcode

Hello @Reyes4711-S73 Thanks for the applied fixes.

Only a comment about the value used for field delivery_steps in stock.warehouse can you review please.

maintenance_stock/data/demo_maintenance_stock.xml

Reyes4711-S73 · 2023-09-04T08:30:36Z

@mamcode Change done

mamcode

Hello @Reyes4711-S73 thanks, but there are still some smaller details to fix.

maintenance_stock/data/demo_maintenance_stock.xml

Reyes4711-S73 · 2023-09-18T06:47:02Z

@mamcode done

mamcode

Thanks @Reyes4711-S73

mamcode · 2023-09-19T00:01:28Z

@dalonsod Can you check this PR again please?

dalonsod

Tested in runboat 👍 but see at code review required changes

maintenance_stock/models/maintenance_equipment.py

mamcode · 2023-09-24T14:18:49Z

@dalonsod @Reyes4711-S73 Hello, I see errors in the Odoo test job that seem to have nothing to do with the code of this PR, how can we run the jobs again?

dalonsod · 2023-09-25T06:58:26Z

Hello @mamcode , it's a known issue, please check odoo/odoo#122569 (comment)

Currently translated at 96.7% (29 of 30 strings) Translation: maintenance-12.0/maintenance-12.0-maintenance_stock Translate-URL: https://translation.odoo-community.org/projects/maintenance-12-0/maintenance-12-0-maintenance_stock/es/

Currently translated at 100.0% (30 of 30 strings) Translation: maintenance-12.0/maintenance-12.0-maintenance_stock Translate-URL: https://translation.odoo-community.org/projects/maintenance-12-0/maintenance-12-0-maintenance_stock/pt_BR/

Currently translated at 100.0% (30 of 30 strings) Translation: maintenance-12.0/maintenance-12.0-maintenance_stock Translate-URL: https://translation.odoo-community.org/projects/maintenance-12-0/maintenance-12-0-maintenance_stock/it/

github-actions · 2025-06-22T12:22:58Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions · 2025-11-02T12:22:23Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions · 2026-03-15T12:34:58Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

Reyes4711-S73 force-pushed the 14.0-mig-maintenance_stock branch from edb1746 to 78728b3 Compare July 6, 2023 06:42

Reyes4711-S73 force-pushed the 14.0-mig-maintenance_stock branch from 78728b3 to f20543b Compare July 6, 2023 07:04

Reyes4711-S73 force-pushed the 14.0-mig-maintenance_stock branch from f20543b to bc0a774 Compare July 7, 2023 06:22

mamcode reviewed Jul 9, 2023

View reviewed changes

Reyes4711-S73 force-pushed the 14.0-mig-maintenance_stock branch 6 times, most recently from c9e4180 to 3ee7028 Compare August 16, 2023 08:16

mamcode reviewed Sep 3, 2023

View reviewed changes

maintenance_stock/data/demo_maintenance_stock.xml Outdated Show resolved Hide resolved

Reyes4711-S73 force-pushed the 14.0-mig-maintenance_stock branch from 3ee7028 to 117ae55 Compare September 4, 2023 08:25

mamcode suggested changes Sep 11, 2023

View reviewed changes

maintenance_stock/data/demo_maintenance_stock.xml Outdated Show resolved Hide resolved

maintenance_stock/data/demo_maintenance_stock.xml Outdated Show resolved Hide resolved

Reyes4711-S73 force-pushed the 14.0-mig-maintenance_stock branch 2 times, most recently from 74ce106 to 3c453fe Compare September 18, 2023 06:43

mamcode approved these changes Sep 19, 2023

View reviewed changes

dalonsod suggested changes Sep 21, 2023

View reviewed changes

maintenance_stock/models/maintenance_equipment.py Outdated Show resolved Hide resolved

Reyes4711-S73 force-pushed the 14.0-mig-maintenance_stock branch 2 times, most recently from 9efae1f to b573f37 Compare September 22, 2023 05:58

Reyes4711-S73 force-pushed the 14.0-mig-maintenance_stock branch from b573f37 to 3ab39ac Compare September 25, 2023 05:59

dalonsod and others added 13 commits February 10, 2025 07:59

[ADD] maintenance_stock

221dc51

[UPD] Update maintenance_stock.pot

654a31f

[ADD] icon.png

cdb71af

Added translation using Weblate (Spanish)

d3adf58

Translated using Weblate (Spanish)

11babdc

Currently translated at 96.7% (29 of 30 strings) Translation: maintenance-12.0/maintenance-12.0-maintenance_stock Translate-URL: https://translation.odoo-community.org/projects/maintenance-12-0/maintenance-12-0-maintenance_stock/es/

Added translation using Weblate (Portuguese (Brazil))

7b81b04

Translated using Weblate (Portuguese (Brazil))

963d1ef

Currently translated at 100.0% (30 of 30 strings) Translation: maintenance-12.0/maintenance-12.0-maintenance_stock Translate-URL: https://translation.odoo-community.org/projects/maintenance-12-0/maintenance-12-0-maintenance_stock/pt_BR/

Added translation using Weblate (Italian)

1a54a07

Translated using Weblate (Italian)

3b96385

Currently translated at 100.0% (30 of 30 strings) Translation: maintenance-12.0/maintenance-12.0-maintenance_stock Translate-URL: https://translation.odoo-community.org/projects/maintenance-12-0/maintenance-12-0-maintenance_stock/it/

Translated using Weblate (Italian)

3e11d11

Currently translated at 100.0% (30 of 30 strings) Translation: maintenance-12.0/maintenance-12.0-maintenance_stock Translate-URL: https://translation.odoo-community.org/projects/maintenance-12-0/maintenance-12-0-maintenance_stock/it/

[IMP] maintenance_stock: pre-commit execution

4a66cc0

[MIG] maintenance_stock: Migration to 13.0

921a16a

[IMP] maintenance_stock: black, isort, prettier

ef33c3d

Reyes4711-S73 force-pushed the 14.0-mig-maintenance_stock branch 2 times, most recently from c5ebbea to b72ea82 Compare February 10, 2025 07:03

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 16, 2025

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 22, 2025

Reyes4711-S73 force-pushed the 14.0-mig-maintenance_stock branch from b72ea82 to 13863ea Compare June 23, 2025 06:06

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 29, 2025

Vicent-S73 pushed a commit to Studio73/e-commerce that referenced this pull request Aug 12, 2025

build(odoo): add OCA/maintenance#347

a3abecc

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 2, 2025

Reyes4711-S73 force-pushed the 14.0-mig-maintenance_stock branch from 13863ea to 4e91dd0 Compare November 3, 2025 11:02

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 9, 2025

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 15, 2026

[MIG] maintenance_stock: Migration to 14.0

d224c50

Reyes4711-S73 force-pushed the 14.0-mig-maintenance_stock branch from 4e91dd0 to d224c50 Compare March 16, 2026 07:17

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 22, 2026

	eval="[[('state','=','draft'),('id', '=', ref('maintenance_stock.stock_inventory_toner'))]]"
	eval="[[('state','=','confirm'),('id', '=', ref('maintenance_stock.stock_inventory_toner'))]]"

Uh oh!

Conversation

Reyes4711-S73 commented Jul 6, 2023

Uh oh!

dalonsod commented Jul 6, 2023

Uh oh!

Reyes4711-S73 commented Jul 6, 2023

Uh oh!

dalonsod commented Jul 6, 2023

Uh oh!

mamcode Jul 9, 2023

Choose a reason for hiding this comment

Uh oh!

dalonsod commented Jul 11, 2023

Uh oh!

Reyes4711-S73 commented Aug 16, 2023

Uh oh!

mamcode left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reyes4711-S73 commented Sep 4, 2023

Uh oh!

mamcode left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reyes4711-S73 commented Sep 18, 2023

Uh oh!

mamcode left a comment

Choose a reason for hiding this comment

Uh oh!

mamcode commented Sep 19, 2023

Uh oh!

dalonsod left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mamcode commented Sep 24, 2023

Uh oh!

dalonsod commented Sep 25, 2023

Uh oh!

github-actions bot commented Jun 22, 2025

Uh oh!

github-actions bot commented Nov 2, 2025

Uh oh!

github-actions bot commented Mar 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants