Skip to content

[19.0][MIG] mail_restrict_send_button#159

Merged
OCA-git-bot merged 19 commits intoOCA:19.0from
dixmit:19.0-mig-mail_restrict_send_button
Mar 6, 2026
Merged

[19.0][MIG] mail_restrict_send_button#159
OCA-git-bot merged 19 commits intoOCA:19.0from
dixmit:19.0-mig-mail_restrict_send_button

Conversation

@etobella
Copy link
Member

@etobella etobella commented Mar 4, 2026

We have improved a little the permission settings

Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in runboat and it works as expected.

Just minor suggestions...

@etobella etobella force-pushed the 19.0-mig-mail_restrict_send_button branch from 3c43451 to 2a69255 Compare March 5, 2026 07:32
@etobella
Copy link
Member Author

etobella commented Mar 5, 2026

@yostashiro comments attended 😄

Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM. 👍

@etobella
Copy link
Member Author

etobella commented Mar 5, 2026

@dreispt as maintainer you might be interested 😄

def migrate(env, version):
openupgrade.set_xml_ids_noupdate_value(
env, "mail_restrict_send_button", ["group_show_send_message_button"], False
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice trick!

Copy link
Member

@dreispt dreispt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I had completely forgotten about this module. I don't think I'm actively using it.

@etobella
Copy link
Member Author

etobella commented Mar 5, 2026

@dreispt Jejeje, that happens... do you want me to remove you from maintainers?

@dreispt
Copy link
Member

dreispt commented Mar 5, 2026

@etobella You're welcome to take it if you like it.

@etobella
Copy link
Member Author

etobella commented Mar 6, 2026

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 19.0-ocabot-merge-pr-159-by-etobella-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 733f9fb. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 3224a04 into OCA:19.0 Mar 6, 2026
7 checks passed
@etobella etobella deleted the 19.0-mig-mail_restrict_send_button branch March 6, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.