Conversation
|
/ocabot migration subscription_oca |
|
@stferraro The commit history looks really weird, you need to keep the history of the module I expect to see those commits: https://github.com/OCA/contract/commits/17.0/subscription_oca (translation commits can be merged) Please find here the whole instructions for module migration: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-19.0 |
|
@yvaucher ok close this pr and open new with this change for migrate this module |
|
You can push force on this one to fix it, no need to close it. |
Currently translated at 95.7% (159 of 166 strings) Translation: contract-16.0/contract-16.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-16-0/contract-16-0-subscription_oca/nl/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/
Currently translated at 100.0% (163 of 163 strings) Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/it/
Currently translated at 92.6% (151 of 163 strings) Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/fi/
Currently translated at 58.8% (96 of 163 strings) Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/tr/
Currently translated at 61.3% (100 of 163 strings) Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/tr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/
Currently translated at 100.0% (164 of 164 strings) Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/it/
Currently translated at 100.0% (164 of 164 strings) Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/tr/
Currently translated at 100.0% (164 of 164 strings) Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/ca/
1426a10 to
46e3239
Compare
|
@yvaucher check pr now ! |
|
Are you guys also having a look at reported bugs in previous versions when doing this migration? Would be really appreciated if this weird behavior was taken care of in [19.0] |
|
"Hi @rickard-w, I have addressed the issue described in bug #1320. I modified the _compute_discount logic to ensure that manual discounts are preserved when changing the product quantity. Additionally, I've added a new regression test test_manual_discount_persistence to verify the fix and prevent this from happening again in the future. Could you please review and verify? Thanks!" |
“Applied the requested test corrections as per review.”