[17.0][FIX] account: Only set res_field=invoice_pdf_report_file on customer invoice/refunds#5551
Merged
pedrobaeza merged 1 commit intoOCA:17.0from Mar 5, 2026
Conversation
pedrobaeza
approved these changes
Mar 5, 2026
Member
|
The effect on this is that if the invoice is reset to draft, the attachment is auto-removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current behavior: On ir.attachment of invoices, 'res_field' is set to 'invoice_pdf_report_file' on all invoices that have 'message_main_attachment_id'
New behavior: only do that for customer invoices and refunds
Why ? Because supplier invoices/refunds can also have 'message_main_attachment_id', for example when you click on the "Upoad" button of the purchase journal on the accounting dashboard and you upload a PDF file. And we don't want res_field='invoice_pdf_report_file' on attachments of supplier invoice/refunds !