Improve Github Actions Setup#17
Merged
NthTensor merged 5 commits intoNthTensor:mainfrom Jun 19, 2025
BD103:actions-improvements
Merged
Improve Github Actions Setup#17NthTensor merged 5 commits intoNthTensor:mainfrom BD103:actions-improvements
NthTensor merged 5 commits intoNthTensor:mainfrom
BD103:actions-improvements
Conversation
NthTensor
approved these changes
Jun 18, 2025
Owner
NthTensor
left a comment
NthTensor
left a comment
There was a problem hiding this comment.
All looks good to me. You'll just need to rebase on main, there's a conflict since I removed the loom CI action.
Owner
|
Oops, tried to resolve these conflicts manually and it introduced a merge conflict :/ Bear with me here, still getting the hang of maintainership. You might have to remove that most recent commit. |
This is automatically set by `dtolnay/rust-toolchain`.
This is automatically set by `Swatinem/rust-cache`.
Contributor
Author
|
You're good! I rebased, so it should be good to go :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes a few CI-related changes:
Swatinem/rust-cache, which is one of the best Rust-specific caching actions out there. We use it over in TheBevyFlock for the CLI, linter, andbevy_new_2dtemplate. Check out Switch toSwatinem/rust-cacheTheBevyFlock/bevy_cli#402, Switch toSwatinem/rust-cacheTheBevyFlock/bevy_new_2d#381, and Re-assess usage ofSwatinem/rust-cacheaction for caching TheBevyFlock/bevy_new_2d#382 for some more fun details.CARGO_TERM_COLOR: always, sincedtolnay/rust-toolchainautomatically configures it for us.CARGO_INCREMENTAL: 0, sinceSwatinem/rust-cachesets it for us.-C debuginfo=line-tables-onlyfor the entire workflow. This heavily reduces cache sizes by stripping out any debug info that we can't use without a debugger. Unlikedebuginfo=0, however, it still includes line and column information for backtraces, meaning it's still easy to see where a panic came from!This doesn't fix CI fully, unfortunately, as there are changes required that I don't fully understand. (Outdated doc-tests and links, mostly.) It should make it run smoother in the future, however!