Open
Conversation
6bfd015 to
01cde37
Compare
7e39024 to
da7a592
Compare
|
I see that this pull request also does what I've done in #472. However, I don't introduce new symbols due to the symbol sharing, I just leave the sharing as-is. |
Collaborator
Author
|
I was planning to enhance it to do the sharing eventually, so it would be next to perfect. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I started to implement a simple version of
--clean-strtabas suggested in #449.Some attention points:
clean-dynstrso might need work to expand to other sections. But seems to be a good start for later enhancement.--clean-strtabwill actually introduce a few strings because it will undo sharing likevprintfwithprintf. However I still think it's valuable to have it and enhance it later on if necessary.Maybe we should have a set of switches documented as beta due to their complexity? The name renaming and this one could be marked as experimental because it's hard to know I got all fields right.
Then after a couple of releases they could be moved to stable.