Skip to content

python3Packages.snappy: 3.2 -> 3.3.2, modernise#477313

Merged
SuperSandro2000 merged 19 commits intoNixOS:masterfrom
alejo7797:snappy-3.3
Mar 22, 2026
Merged

python3Packages.snappy: 3.2 -> 3.3.2, modernise#477313
SuperSandro2000 merged 19 commits intoNixOS:masterfrom
alejo7797:snappy-3.3

Conversation

@alejo7797
Copy link
Copy Markdown
Contributor

@alejo7797 alejo7797 commented Jan 5, 2026 •
edited
Loading

https://github.com/3-manifolds/SnapPy/releases/tag/3.3_as_released
https://github.com/3-manifolds/SnapPy/releases/tag/3.3.1_as_released
https://github.com/3-manifolds/SnapPy/releases/tag/3.3.2_as_released

See also

Notes

  • Adds tests under passthru.tests which test extra functionality of SnapPy and Spherogram when run within Sage.
  • Adds updateScripts to SnapPy and many of its dependencies.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@alejo7797 alejo7797 changed the title Snappy 3.3 python3Packages.snappy 3.2 -> 3.3 Jan 5, 2026
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 6.topic: python Python is a high-level, general-purpose programming language. labels Jan 5, 2026
@alejo7797

This comment was marked as outdated.

Sign in to view
@alejo7797 alejo7797 force-pushed the snappy-3.3 branch 3 times, most recently from d59a589 to baea857 Compare January 6, 2026 11:40
@alejo7797

This comment was marked as outdated.

Sign in to view
@nixpkgs-ci nixpkgs-ci bot removed the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Jan 6, 2026
@alejo7797

This comment was marked as outdated.

Sign in to view
@alejo7797 alejo7797 marked this pull request as ready for review January 6, 2026 14:45
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jan 6, 2026
@alejo7797 alejo7797 force-pushed the snappy-3.3 branch 3 times, most recently from 40d436b to eb14ea5 Compare January 6, 2026 20:06
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. and removed 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. labels Jan 6, 2026
@alejo7797 alejo7797 force-pushed the snappy-3.3 branch 2 times, most recently from 9ee04ae to f995836 Compare January 6, 2026 22:03
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Jan 6, 2026
@alejo7797 alejo7797 force-pushed the snappy-3.3 branch 2 times, most recently from de8203a to c198bdf Compare January 6, 2026 22:19
@alejo7797

This comment was marked as outdated.

Sign in to view
@alejo7797 alejo7797 changed the title python3Packages.snappy 3.2 -> 3.3.1 python3Packages.snappy 3.2 -> 3.3.2 Mar 6, 2026
@alejo7797

This comment was marked as outdated.

Sign in to view
@alejo7797 alejo7797 changed the title python3Packages.snappy 3.2 -> 3.3.2 python3Packages.snappy: 3.2 -> 3.3.2 Mar 11, 2026
@alejo7797

This comment was marked as outdated.

Sign in to view
SuperSandro2000
SuperSandro2000 reviewed Mar 22, 2026
View reviewed changes
alejo7797 added 14 commits March 22, 2026 16:08
@alejo7797
python3Packages.cypari: rename static library derivation inputs
f2233d1
@alejo7797
python3Packages.cypari: add updateScript
9284474
@alejo7797
python3Packages.cypari: 2.5.5 -> 2.5.6
7b0caf2
@alejo7797
python3Packages.plink: add updateScript
807436d
@alejo7797
python3Packages.plink: 2.4.6 -> 2.4.9
4b8eb30
@alejo7797
python3Packages.snappy-manifolds: add updateScript
4200a82
@alejo7797
python3Packages.snappy-manifolds: 1.2.1 -> 1.4
97b62f9
@alejo7797
python3Packages.spherogram: add checkPhase
b2a36cb
@alejo7797
python3Packages.spherogram: add sage tests
ee41532 
see
https://github.com/3-manifolds/Spherogram/blob/2.4_as_released/.github/workflows/test.yml#L36
@alejo7797
python3Packages.spherogram: add updateScript
9575357
@alejo7797
python3Packages.spherogram: 2.3 -> 2.4.1
f242b99
@alejo7797
python3Packages.snappy: add sage tests
ae0854e 
see
https://github.com/3-manifolds/SnapPy/blob/3.3_as_released/.github/workflows/sage_test.yml
@alejo7797
python3Packages.snappy: add updateScript
180adfe
@alejo7797
python3Packages.snappy: 3.2 -> 3.3.2
b24794f
@alejo7797
Copy link
Copy Markdown
Contributor Author

alejo7797 commented Mar 22, 2026

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 477313
Commit: b24794f9dc3d62d5d4a74a7da3b4a6d1319d1cce (subsequent changes)
Merge: d83ee26d94fa7f7dbc9d6ca4793ec3f2d6fe690d

Logs: https://github.com/alejo7797/nixpkgs-review-gha/actions/runs/23411542772

x86_64-linux

✅ 31 packages built:
  • python313Packages.cypari
  • python313Packages.cypari.dist
  • python313Packages.plink
  • python313Packages.plink.dist
  • snappy-topology (python313Packages.snappy)
  • python313Packages.snappy-15-knots
  • python313Packages.snappy-15-knots.dist
  • python313Packages.snappy-manifolds
  • python313Packages.snappy-manifolds.dist
  • snappy-topology.dist (python313Packages.snappy.dist)
  • snappy-topology.doc (python313Packages.snappy.doc)
  • python313Packages.spherogram
  • python313Packages.spherogram.dist
  • python313Packages.tkinter-gl
  • python313Packages.tkinter-gl.dist
  • python314Packages.cypari
  • python314Packages.cypari.dist
  • python314Packages.plink
  • python314Packages.plink.dist
  • python314Packages.snappy
  • python314Packages.snappy-15-knots
  • python314Packages.snappy-15-knots.dist
  • python314Packages.snappy-manifolds
  • python314Packages.snappy-manifolds.dist
  • python314Packages.snappy.dist
  • python314Packages.snappy.doc
  • python314Packages.spherogram
  • python314Packages.spherogram.dist
  • python314Packages.tkinter-gl
  • python314Packages.tkinter-gl.dist
  • tkgl

aarch64-linux

✅ 31 packages built:
  • python313Packages.cypari
  • python313Packages.cypari.dist
  • python313Packages.plink
  • python313Packages.plink.dist
  • snappy-topology (python313Packages.snappy)
  • python313Packages.snappy-15-knots
  • python313Packages.snappy-15-knots.dist
  • python313Packages.snappy-manifolds
  • python313Packages.snappy-manifolds.dist
  • snappy-topology.dist (python313Packages.snappy.dist)
  • snappy-topology.doc (python313Packages.snappy.doc)
  • python313Packages.spherogram
  • python313Packages.spherogram.dist
  • python313Packages.tkinter-gl
  • python313Packages.tkinter-gl.dist
  • python314Packages.cypari
  • python314Packages.cypari.dist
  • python314Packages.plink
  • python314Packages.plink.dist
  • python314Packages.snappy
  • python314Packages.snappy-15-knots
  • python314Packages.snappy-15-knots.dist
  • python314Packages.snappy-manifolds
  • python314Packages.snappy-manifolds.dist
  • python314Packages.snappy.dist
  • python314Packages.snappy.doc
  • python314Packages.spherogram
  • python314Packages.spherogram.dist
  • python314Packages.tkinter-gl
  • python314Packages.tkinter-gl.dist
  • tkgl

x86_64-darwin (sandbox = relaxed)

✅ 31 packages built:
  • python313Packages.cypari
  • python313Packages.cypari.dist
  • python313Packages.plink
  • python313Packages.plink.dist
  • snappy-topology (python313Packages.snappy)
  • python313Packages.snappy-15-knots
  • python313Packages.snappy-15-knots.dist
  • python313Packages.snappy-manifolds
  • python313Packages.snappy-manifolds.dist
  • snappy-topology.dist (python313Packages.snappy.dist)
  • snappy-topology.doc (python313Packages.snappy.doc)
  • python313Packages.spherogram
  • python313Packages.spherogram.dist
  • python313Packages.tkinter-gl
  • python313Packages.tkinter-gl.dist
  • python314Packages.cypari
  • python314Packages.cypari.dist
  • python314Packages.plink
  • python314Packages.plink.dist
  • python314Packages.snappy
  • python314Packages.snappy-15-knots
  • python314Packages.snappy-15-knots.dist
  • python314Packages.snappy-manifolds
  • python314Packages.snappy-manifolds.dist
  • python314Packages.snappy.dist
  • python314Packages.snappy.doc
  • python314Packages.spherogram
  • python314Packages.spherogram.dist
  • python314Packages.tkinter-gl
  • python314Packages.tkinter-gl.dist
  • tkgl

aarch64-darwin (sandbox = relaxed)

✅ 31 packages built:
  • python313Packages.cypari
  • python313Packages.cypari.dist
  • python313Packages.plink
  • python313Packages.plink.dist
  • snappy-topology (python313Packages.snappy)
  • python313Packages.snappy-15-knots
  • python313Packages.snappy-15-knots.dist
  • python313Packages.snappy-manifolds
  • python313Packages.snappy-manifolds.dist
  • snappy-topology.dist (python313Packages.snappy.dist)
  • snappy-topology.doc (python313Packages.snappy.doc)
  • python313Packages.spherogram
  • python313Packages.spherogram.dist
  • python313Packages.tkinter-gl
  • python313Packages.tkinter-gl.dist
  • python314Packages.cypari
  • python314Packages.cypari.dist
  • python314Packages.plink
  • python314Packages.plink.dist
  • python314Packages.snappy
  • python314Packages.snappy-15-knots
  • python314Packages.snappy-15-knots.dist
  • python314Packages.snappy-manifolds
  • python314Packages.snappy-manifolds.dist
  • python314Packages.snappy.dist
  • python314Packages.snappy.doc
  • python314Packages.spherogram
  • python314Packages.spherogram.dist
  • python314Packages.tkinter-gl
  • python314Packages.tkinter-gl.dist
  • tkgl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@natsukium natsukium Awaiting requested review from natsukium

+1 more reviewer

@noiioiu noiioiu noiioiu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alejo7797 @noiioiu @SuperSandro2000