Remove println calls from jenks and quantile#16
Open
nmandery wants to merge 1 commit intoNik4002:mainfrom
Open
Remove println calls from jenks and quantile#16nmandery wants to merge 1 commit intoNik4002:mainfrom
nmandery wants to merge 1 commit intoNik4002:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for providing this crate.
I noticed a few
printlncalls printing a significant amount of data while using the hinge and jenks implementations. This PR removes these calls, in case these are not intended to be removed, we should switch them to a logging crate liketracing.