[codex] Route generated export through backend writer#801
Draft
ehennestad wants to merge 1 commit intozarr-support/2-add-lazy-array-generalizationfrom
Draft
[codex] Route generated export through backend writer#801ehennestad wants to merge 1 commit intozarr-support/2-add-lazy-array-generalizationfrom
ehennestad wants to merge 1 commit intozarr-support/2-add-lazy-array-generalizationfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This change decouples generated export code from raw HDF5 file identifiers by routing export operations through a backend writer object.
The generated
exportmethods now accept awriterand call writer methods instead of callingio.writeGroup,io.writeDataset, andio.writeAttributedirectly. The handwritten export helpers on the same path were updated to normalize either a writer object or legacy file id input, and the HDF5 path now uses a thinHDF5Writeradapter so behavior stays functionally identical for existing HDF5 export.This keeps the scope limited to the export path while removing another HDF5-hardcoded seam from the architecture.
How to test the behavior?
Checklist
fix #XXwhereXXis the issue number?