[codex] Promote specialized attributes of included typed datasets#797
Open
ehennestad wants to merge 10 commits intorefactor-io-parse-datasetfrom
Open
Conversation
Restore formatting changes unrelated to PR
Restore comment wording
…ributes-of-typed-datasets-to-containing-type
resolution property of spike_times VectorData object was previously cleared when spike_times was added to the units object
bendichter
approved these changes
Apr 1, 2026
…ributes-of-typed-datasets-to-containing-type
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## refactor-io-parse-dataset #797 +/- ##
=============================================================
- Coverage 95.50% 95.45% -0.05%
=============================================================
Files 191 191
Lines 6961 7047 +86
=============================================================
+ Hits 6648 6727 +79
- Misses 313 320 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ributes-of-typed-datasets-to-containing-type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR exposes attributes that are added at the inclusion site of a typed dataset on the containing MATLAB class API using the
dataset_attributenaming pattern.Why
The NWB schema allows a typed dataset reused via
neurodata_type_incto gain additional attributes when it is included into another type. matnwb was not surfacing those specialized attributes consistently in the generated API. This showed up most clearly forUnits.spike_times.resolution.What changed
User impact
Users can access specialized included-dataset attributes directly from the containing type, e.g.
spike_times_resolution, without leaking those attributes onto unrelatedVectorDatainstances.Root cause
The generator handled untyped dataset attributes as dependent properties on the containing class, but typed reused datasets did not have an equivalent schema-driven path. A temporary hidden-property-based heuristic also turned out to be too tied to legacy
VectorDatapatching.Validation
2.9.0tests.system.UnitTimesIOTest.testRoundTripUnitsexposesspike_times_resolutionSimultaneousRecordingsTabledoes not exposerecordings_table