refactor(rpc): starknet_call data parameters to allow hex decimal numbes only#3488
Draft
MaksymMalicki wants to merge 2 commits intomainfrom
Draft
refactor(rpc): starknet_call data parameters to allow hex decimal numbes only#3488MaksymMalicki wants to merge 2 commits intomainfrom
starknet_call data parameters to allow hex decimal numbes only#3488MaksymMalicki wants to merge 2 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3488 +/- ##
==========================================
+ Coverage 75.37% 75.45% +0.07%
==========================================
Files 382 382
Lines 34838 34863 +25
==========================================
+ Hits 26260 26306 +46
+ Misses 6729 6710 -19
+ Partials 1849 1847 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MaksymMalicki
temporarily deployed
to
Development
GitHub Actions
Inactive
MaksymMalicki
temporarily deployed
to
Development
GitHub Actions
Inactive
rodrodros
reviewed
Mar 18, 2026
Comment on lines
+62
to
+67
| // LimitSliceHex is like LimitSlice[T, L] but only accepts 0x-prefixed | ||
| // hexadecimal strings during JSON unmarshaling, rejecting decimal and bare-hex | ||
| type LimitSliceHex[T any, L Limit] struct { | ||
| Data []T `validate:"dive"` | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Why create this type, I think it shouldn't exists. I see now that felt.Felt allows Unmarshalling both numbers and strings.
If that's the case, we should then consider fixing it at the root, that is, the felt type only allow hexadecimals, or not proceed at all with this feature.
Contributor
There was a problem hiding this comment.
Adding a new type is unnecessary complexity to address an implementation detail of felt.Felt
rodrodros
changed the title
starknet_call data parameters to allow hex decimal numbes onlystarknet_call data parameters to allow hex decimal numbes only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.