refactor(triedb): add clean cache to the rawDB engine#3188
Closed
MaksymMalicki wants to merge 1 commit intomaksym/integrate-common-interface-rawdbfrom
Closed
refactor(triedb): add clean cache to the rawDB engine#3188MaksymMalicki wants to merge 1 commit intomaksym/integrate-common-interface-rawdbfrom
MaksymMalicki wants to merge 1 commit intomaksym/integrate-common-interface-rawdbfrom
Conversation
MaksymMalicki
changed the base branch from
main
to
maksym/integrate-common-interface-rawdb
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## maksym/integrate-common-interface-rawdb #3188 +/- ##
==========================================================================
Coverage ? 75.83%
==========================================================================
Files ? 329
Lines ? 32655
Branches ? 0
==========================================================================
Hits ? 24765
Misses ? 6119
Partials ? 1771 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MaksymMalicki
temporarily deployed
to
Development
GitHub Actions
Inactive
MaksymMalicki
force-pushed
the
maksym/integrate-common-interface-rawdb
branch
from
33d81d5 to
dc23482
Compare
MaksymMalicki
force-pushed
the
maksym/rawdb-clean-cache
branch
from
92babba to
0ca4517
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should be reviewed after #3187
pathDBinto therawDB. They are meant to be reviewed and benchmarked separately, to measure the impact on the new state performance.rawDB. The state is meant to read from this layer before the direct PebbleDB hit. We write to clean cache on read miss and also when flushing the nodes to the DB.Next PR to review: #3192