Fix macOS build, file dialog, and dark mode UI#195
Open
volkan-a wants to merge 4 commits intoNatLabRockies:developfrom
Open
Fix macOS build, file dialog, and dark mode UI#195volkan-a wants to merge 4 commits intoNatLabRockies:developfrom
volkan-a wants to merge 4 commits intoNatLabRockies:developfrom
Conversation
volkan-a
force-pushed
the
fix-macos-build-and-dark-mode
branch
from
20dc995 to
3dd02a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces three targeted fixes for DView on macOS when compiling with modern toolchains and running on newer macOS versions.
nrows()/ncols()calls toRows()/Cols()and handled anullptrambiguity issue inpdfdc.cpp.wxFileDialog::ShowModalby properly registeringDView.appas a macOS Bundle with a uniquegov.nrel.dviewBundle Identifier, and signing it withcom.apple.security.files.user-selected.*entitlements automatically during the CMake build process.wxDVSelectionListCtrlto dynamically calculate background luminance and enforce high-contrast foreground text and checkboxes, fixing the invisible black-on-dark-grey text issue when macOS is in Dark Mode.