Skip to content

Split ITC basis by tech part 1b: Refactor other financial modules#1376

Open
brtietz wants to merge 8 commits intodevelopfrom
itc_basis_updates
Open

Split ITC basis by tech part 1b: Refactor other financial modules#1376
brtietz wants to merge 8 commits intodevelopfrom
itc_basis_updates

Conversation

@brtietz
Copy link
Collaborator

@brtietz brtietz commented Mar 23, 2026

Apply #1370 to all of the financial models that use the same structure.

No behavior should change with this PR, this is refactor-only.

I'll admit that my ordering conventions for CBI/IBI and reserves were a bit inconsistent. If this is bothersome I can put in a little work to standardize.

Next step will be adding SSC inputs and allowing for the new basis calcs.

After that this structure will be applied to other compute modules, like cashloan. (if we still think that's a good idea)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 23449447889

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 932 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-2.0%) to 56.29%

Files with Coverage Reduction New Missed Lines %
ssc/ssc/cmod_equpartflip.cpp 63 93.33%
ssc/ssc/cmod_saleleaseback.cpp 68 93.32%
ssc/ssc/cmod_levpartflip.cpp 75 93.63%
ssc/ssc/cmod_singleowner.cpp 84 92.35%
ssc/ssc/cmod_merchantplant.cpp 88 91.43%
ssc/ssc/cmod_host_developer.cpp 95 91.67%
ssc/ssc/cmod_communitysolar.cpp 209 81.72%
ssc/ssc/cmod_singleowner_heat.cpp 250 77.01%
Totals Coverage Status
Change from base Build 23365037156: -2.0%
Covered Lines: 68177
Relevant Lines: 121118

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants