Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is not ready for merging; it currently builds upon #224.
A few parameters of this model are still uncertain, and we should reach out for clarification on them, including
OFF_HOT,OFF_WARM,OFF_COLD), but should discuss.I added a DEFAULTS dict in
LinearGeneratorto simplify the checking and testing of these values. No need to do this for past components, but it could be helpful for others going forward.In the example, I'm modeling a single linear generator to demonstrate it's features. Typically, it will be used in an array, but that is a separate feature/example and we can work on more control approaches in Hycon. I'm open to feedback on the example.
I'm not sure if we want to specifically call out Mainspring, but that is where a lot of our information has come from.
TODO:
OFF_*states