Merged
Conversation
…to develop_fx_bugfix updating from origin
enable tcp helics cores
…to develop_fx_bugfix
AadilLatif
approved these changes
Apr 7, 2026
Collaborator
AadilLatif
left a comment
AadilLatif
left a comment
There was a problem hiding this comment.
@nadiavpI see alot of commented log lines. I would reccomend cleaning it up before you merge. Also use logger config to overwrite exisiting log files. Other than that the PR looks clean.
| """ | ||
|
|
||
| results = {} | ||
| # logger.info(self.profiles) |
pypsse/utils/dynamic_utils.py
Outdated
| if self.settings.helics and self.settings.helics.cosimulation_mode: | ||
| sub_data = pd.read_csv(self.settings.simulation.subscriptions_file) | ||
| sub_data = sub_data[sub_data["element_type"] == "Load"] | ||
| ### add by Aadil |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR accomplishes:
The goal is to get this synced with main so that future branches and PRs have smaller changes and projects are up to date with main.