Skip to content

Final Project with Changes#6

Open
Naman1109 wants to merge 2 commits intomainfrom
Adv_Java_Project_Final
Open

Final Project with Changes#6
Naman1109 wants to merge 2 commits intomainfrom
Adv_Java_Project_Final

Conversation

@Naman1109
Copy link
Owner

No description provided.

Copy link

@ashishvijaywargiya ashishvijaywargiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall a good efforts. Thank you Naman. Here are a few general feedback:

  1. Please follow the naming convention for the Filename, variable name.

String e1 = request.getParameter("email");
String f1 = request.getParameter("fname");
The variable names like above is a bad practice. Please fix it everywhere.

  1. Username and password to connect the DB should not be used like you have used in the code. Please use Property Files: https://www.baeldung.com/java-properties

  2. And please try to find the reason why you need to do mapping for Servlet in the web.xml file.

  3. You should not use the "Exception" class in all the places, instead of that you should understand the Exception Hierarchy and use proper classes.

  4. Only import the class which are required in your work instead of using the "*" to import all the classes in any package. This is a bad practice.

import java.sql.*;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants