Conversation
ashishvijaywargiya
left a comment
There was a problem hiding this comment.
Overall a good efforts. Thank you Naman. Here are a few general feedback:
- Please follow the naming convention for the Filename, variable name.
String e1 = request.getParameter("email");
String f1 = request.getParameter("fname");
The variable names like above is a bad practice. Please fix it everywhere.
-
Username and password to connect the DB should not be used like you have used in the code. Please use Property Files: https://www.baeldung.com/java-properties
-
And please try to find the reason why you need to do mapping for Servlet in the web.xml file.
-
You should not use the "Exception" class in all the places, instead of that you should understand the Exception Hierarchy and use proper classes.
-
Only import the class which are required in your work instead of using the "*" to import all the classes in any package. This is a bad practice.
import java.sql.*;
No description provided.