Open
Conversation
yashwantdhakad
approved these changes
May 23, 2022
yashwantdhakad
left a comment
yashwantdhakad
left a comment
There was a problem hiding this comment.
Added a few minor suggestions
| class Employee implements Serializable { | ||
|
|
||
| String Name; | ||
| String Email_Address; |
There was a problem hiding this comment.
variable name should be lower camel case.
| Scanner sc = new Scanner(System.in); | ||
|
|
||
| System.out.println("Pkease Enter Name..!"); | ||
| String Name = sc.nextLine(); |
There was a problem hiding this comment.
same here please use lower camel case for variable name.
| while (litr.hasNext()) { | ||
| Employee emp = (Employee) litr.next(); | ||
| if (emp.Name.equals(Name)) { | ||
| System.out.println(emp); |
There was a problem hiding this comment.
If employ found then you can break this loop
| while (litr.hasNext()) { | ||
| Employee emp = (Employee) litr.next(); | ||
| if (emp.Name.equals(Name)) { | ||
| litr.remove(); |
There was a problem hiding this comment.
If employ found you can break this loop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assignment_3 Added.