323 Refactor community district query parameters#324
Open
dhochbaum-dcp wants to merge 3 commits intomainfrom
Open
323 Refactor community district query parameters#324dhochbaum-dcp wants to merge 3 commits intomainfrom
dhochbaum-dcp wants to merge 3 commits intomainfrom
Conversation
TangoYankee
suggested changes
Jan 27, 2026
| ? { communityDistrictId: `${boroughId}${districtId}` } | ||
| ? { boroughId, communityDistrictId: districtId } | ||
| : {}), | ||
| ...(boroughId !== null && districtId === null && districtType === "cd" |
Contributor
There was a problem hiding this comment.
Do we want to be filtering by borough when the district type is community district?
This applies here in the budget request, later in the capital project json, and finally in the budget request csv
Contributor
Author
There was a problem hiding this comment.
Yes, that was my intent.
| ...(agencyBudget === null ? {} : { agencyBudget }), | ||
| ...(commitmentsTotalMin === null ? {} : { commitmentsTotalMin }), | ||
| ...(commitmentsTotalMax === null ? {} : { commitmentsTotalMax }), | ||
| ...(districtId !== null ? {} : { isMapped: true }), |
Contributor
There was a problem hiding this comment.
We're expected to only show mapped capital projects. When we're removing the "isMapped" check, are we preserving the functionality some other way?
Contributor
Author
There was a problem hiding this comment.
Good catch - I've re-added an updated version of the isMapped check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be merged with NYCPlanning/ae-zoning-api#552 and NYCPlanning/ae-zoning-api#553 so that the changes do not break functionality.
Closes #323