Move top level project detection above project call#1941
Merged
ericniebler merged 1 commit intoNVIDIA:mainfrom Mar 19, 2026
Merged
Move top level project detection above project call#1941ericniebler merged 1 commit intoNVIDIA:mainfrom
ericniebler merged 1 commit intoNVIDIA:mainfrom
Conversation
Collaborator
|
/ok to test f2312ad |
Collaborator
|
/ok to test 0d6ab66 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry missed the project call. Thought it was more below.
Didn't use the proposed the path detection logic in #1938 as the path based approach is false in case when a cmake build tree has never called project before (e.g. master builds building multiple projects at once)
fixes #1938