fix: preserve explicit provider options for matching implicit profiles#20
fix: preserve explicit provider options for matching implicit profiles#20saschabuehrle wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
|
There's currently a That lets users explicitly choose which MSC profile to use for S3 URLs instead of choosing the first matching profile in the configuration. Tie breaking based on appearance order can be difficult to reason about if using the MSC configuration merging feature. |
|
Thanks for the pointer on — agreed, that setting is the right option when explicit remaps are needed.\n\nThe intent of this patch is narrower: keep explicitly provided provider options intact when profile auto-resolution still lands on the same implicit provider profile. That way existing explicit endpoint/region overrides aren't dropped unexpectedly.\n\nIf you'd like, I can add a short note in docs clarifying when to use vs profile option overrides.\n\nGreetings, saschabuehrle |
|
Small correction to my previous comment (shell formatting ate the inline code style): Thanks for the pointer on The intent of this patch is narrower: keep explicitly provided provider options intact when profile auto-resolution still lands on the same implicit provider profile. That way existing explicit endpoint/region overrides aren't dropped unexpectedly. If you'd like, I can add a short docs note clarifying when to use Greetings, saschabuehrle |
|
Implicit profile names are an internal detail that's subject to change. There's no guarantee that these profiles will always be named That makes automatic merging with a user-defined profile named
|
Bug
Fixes #19 — when
resolve_storage_client()uses an implicit profile like_s3-my-bucket,StorageClientConfig.from_file()rebuilt the profile with onlybase_path, so explicit options (for exampleendpoint_url) were dropped.Fix
s3-my-bucket) already exists with the same provider type andbase_path.Testing
uv run pytest -q tests/test_multistorageclient/unit/test_implicit_profile_config.pyHappy to address any feedback.
Greetings, saschabuehrle