mk/docker.mk: Add Podman support and fix version/artifact handling#359
Open
flouthoc wants to merge 1 commit intoNVIDIA:mainfrom
Open
mk/docker.mk: Add Podman support and fix version/artifact handling#359flouthoc wants to merge 1 commit intoNVIDIA:mainfrom
flouthoc wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
- Use $(DOCKER) for pull, build, run, images, and rmi so DOCKER=podman works - Add IMAGE_PREFIX (localhost/ with Podman) and VOLUME_OPTS (:z for Podman/SELinux) - Add DOCKER_BUILD_FMT (--format docker with Podman) so SHELL and bash RUN work - Create ARTIFACTS_DIR before container run (mkdir -p) Signed-off-by: flouthoc <flouthoc.git@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR similar to NVIDIA/nvidia-container-toolkit#1700