apt(-get) operations that require network: do not suppress stdout/err…#643
Open
apt(-get) operations that require network: do not suppress stdout/err…#643
Conversation
…, timeout-control Signed-off-by: Shiva Kumar (SW-CLOUD) <shivaku@nvidia.com>
shivakunv
requested review from
cdesiniotis,
rahulait,
rajathagasthya and
tariq1890
Contributor
Author
|
PTAL |
| } | ||
|
|
||
| # Run apt-get -qq quietly, on failure print actual error to stdout and exit. | ||
| _apt_quiet() { |
Contributor
There was a problem hiding this comment.
Why are we running apt-get quietly if the motivation is to have verbose logs?
Contributor
Author
There was a problem hiding this comment.
verbose logs will be generated only when errors occur, will be ignored onsucces.
Also, go back to plain apt-get -qq ... with no > /dev/null or 2>/dev/null.
-qq only quiets apt-get itself. It does not silence dpkg or maintainer scripts .
So you still get output such as :
“(Reading database …)”
“Selecting previously unselected package …”
“Unpacking …” / “Setting up …”
“Processing triggers for …” (e.g. man-db, systemd)
We can expect a text output of about 10 to 100 lines(few kbs).
_apt_quiet function will suppress this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github issue : #347