fix(ci): harden CI image tool installation#572
Merged
Conversation
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
pimlock
commented
Mar 24, 2026
Collaborator
Author
|
It now installs correct version of Python: https://github.com/NVIDIA/OpenShell/actions/runs/23508215060/job/68421856043#step:5:217 (this was fixed in v2026.3.10: jdx/mise#8672). |
drew
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This hardens the CI image build so tool installation behaves deterministically and fails loudly when
mise installbreaks. It also removes the unused AWS CLI from the image.Related Issue
N/A
Changes
miseinstaller version indeploy/docker/Dockerfile.cimise reshimsouvand other tool shims are always present in the CI image|| truetorustup component remove rust-docssomise installfailures fail the Docker buildTesting
mise run pre-commitpassesdocker buildx build --load -t openshell/ci:debug -f deploy/docker/Dockerfile.ci .docker run --rm -v \"/Users/pmlocek/dev/navigator:/repo\" -w /repo openshell/ci:debug sh -lc 'mise trust /repo >/dev/null && uv --version && command -v aws >/dev/null; test $? -ne 0'Checklist