Skip to content

fix(ci): harden CI image tool installation#572

Merged
pimlock merged 1 commit intomainfrom
fix/ci-image-mise-uv
Mar 24, 2026
Merged

fix(ci): harden CI image tool installation#572
pimlock merged 1 commit intomainfrom
fix/ci-image-mise-uv

Conversation

@pimlock
Copy link
Collaborator

@pimlock pimlock commented Mar 24, 2026

Summary

This hardens the CI image build so tool installation behaves deterministically and fails loudly when mise install breaks. It also removes the unused AWS CLI from the image.

Related Issue

N/A

Changes

  • pin the mise installer version in deploy/docker/Dockerfile.ci
  • run mise reshim so uv and other tool shims are always present in the CI image
  • scope the || true to rustup component remove rust-docs so mise install failures fail the Docker build
  • remove the unused AWS CLI installation from the CI image

Testing

  • mise run pre-commit passes
  • Unit tests added/updated
  • E2E tests added/updated (if applicable)
  • docker buildx build --load -t openshell/ci:debug -f deploy/docker/Dockerfile.ci .
  • docker run --rm -v \"/Users/pmlocek/dev/navigator:/repo\" -w /repo openshell/ci:debug sh -lc 'mise trust /repo >/dev/null && uv --version && command -v aws >/dev/null; test $? -ne 0'

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
@pimlock pimlock requested a review from a team as a code owner March 24, 2026 19:21
@pimlock pimlock self-assigned this Mar 24, 2026
@pimlock
Copy link
Collaborator Author

pimlock commented Mar 24, 2026

It now installs correct version of Python: https://github.com/NVIDIA/OpenShell/actions/runs/23508215060/job/68421856043#step:5:217 (this was fixed in v2026.3.10: jdx/mise#8672).

@pimlock pimlock merged commit fbdc4c6 into main Mar 24, 2026
11 of 16 checks passed
@pimlock pimlock deleted the fix/ci-image-mise-uv branch March 24, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants