fix: correct Telegram bridge status detection (fixes #587)#614
Open
kagura-agent wants to merge 1 commit intoNVIDIA:mainfrom
Open
fix: correct Telegram bridge status detection (fixes #587)#614kagura-agent wants to merge 1 commit intoNVIDIA:mainfrom
kagura-agent wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
stop() and showStatus() were not passing SANDBOX_NAME to start-services.sh, causing it to default to 'default' while start() passed the actual sandbox name from the registry. This meant the PID directory used by stop/status (/tmp/nemoclaw-services-default/) was different from the one used by start (/tmp/nemoclaw-services-<name>/), so status always reported 'stopped' and stop never found the running process. Extract sandboxEnvPrefix() helper and use it consistently in start(), stop(), and showStatus() so all three resolve SANDBOX_NAME the same way.
📝 WalkthroughWalkthroughIntroduced a centralized Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment Tip CodeRabbit can approve the review once all CodeRabbit's comments are resolved.Enable the |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@test/service-env.test.js`:
- Around line 151-162: The test currently counts occurrences of
sandboxEnvPrefix() which can include the helper declaration and thus miss a
missing call in start(); update the test to explicitly assert that the start()
implementation calls sandboxEnvPrefix() (in addition to stop() and showStatus())
— e.g., search the source for the start function body and assert it contains
sandboxEnvPrefix(), and keep the existing count/assertions for stop() and
showStatus() to ensure all three call sites exist; reference sandboxEnvPrefix()
and start(), stop(), showStatus() to locate the relevant checks in the test.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 1d6c88c6-c7df-402a-963b-87540432b60f
📒 Files selected for processing (2)
bin/nemoclaw.jstest/service-env.test.js
Comment on lines
+151
to
+162
| it("sandboxEnvPrefix() is a shared helper used by start, stop, and status", () => { | ||
| const fs = require("fs"); | ||
| const src = fs.readFileSync( | ||
| path.join(__dirname, "..", "bin", "nemoclaw.js"), | ||
| "utf-8" | ||
| ); | ||
| const uses = (src.match(/sandboxEnvPrefix\(\)/g) || []).length; | ||
| // At least 3 call sites: start(), stop(), showStatus() | ||
| assert.ok( | ||
| uses >= 3, | ||
| `sandboxEnvPrefix() should be called at least 3 times (start/stop/status), found ${uses}` | ||
| ); |
There was a problem hiding this comment.
sandboxEnvPrefix() count check can miss a start() regression.
At Line 157, the regex also matches the helper declaration, so uses >= 3 can still pass with only declaration + stop() + showStatus() and no start() usage.
✅ Suggested test hardening
- it("sandboxEnvPrefix() is a shared helper used by start, stop, and status", () => {
+ it("start() passes SANDBOX_NAME via sandboxEnvPrefix", () => {
const fs = require("fs");
const src = fs.readFileSync(
path.join(__dirname, "..", "bin", "nemoclaw.js"),
"utf-8"
);
- const uses = (src.match(/sandboxEnvPrefix\(\)/g) || []).length;
- // At least 3 call sites: start(), stop(), showStatus()
- assert.ok(
- uses >= 3,
- `sandboxEnvPrefix() should be called at least 3 times (start/stop/status), found ${uses}`
- );
+ const startFn = src.match(/async function start\(\)[^]*?^}/m);
+ assert.ok(startFn, "start() function must exist");
+ assert.ok(
+ startFn[0].includes("sandboxEnvPrefix"),
+ "start() must call sandboxEnvPrefix() to resolve SANDBOX_NAME"
+ );
});📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| it("sandboxEnvPrefix() is a shared helper used by start, stop, and status", () => { | |
| const fs = require("fs"); | |
| const src = fs.readFileSync( | |
| path.join(__dirname, "..", "bin", "nemoclaw.js"), | |
| "utf-8" | |
| ); | |
| const uses = (src.match(/sandboxEnvPrefix\(\)/g) || []).length; | |
| // At least 3 call sites: start(), stop(), showStatus() | |
| assert.ok( | |
| uses >= 3, | |
| `sandboxEnvPrefix() should be called at least 3 times (start/stop/status), found ${uses}` | |
| ); | |
| it("start() passes SANDBOX_NAME via sandboxEnvPrefix", () => { | |
| const fs = require("fs"); | |
| const src = fs.readFileSync( | |
| path.join(__dirname, "..", "bin", "nemoclaw.js"), | |
| "utf-8" | |
| ); | |
| const startFn = src.match(/async function start\(\)[^]*?^}/m); | |
| assert.ok(startFn, "start() function must exist"); | |
| assert.ok( | |
| startFn[0].includes("sandboxEnvPrefix"), | |
| "start() must call sandboxEnvPrefix() to resolve SANDBOX_NAME" | |
| ); | |
| }); |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@test/service-env.test.js` around lines 151 - 162, The test currently counts
occurrences of sandboxEnvPrefix() which can include the helper declaration and
thus miss a missing call in start(); update the test to explicitly assert that
the start() implementation calls sandboxEnvPrefix() (in addition to stop() and
showStatus()) — e.g., search the source for the start function body and assert
it contains sandboxEnvPrefix(), and keep the existing count/assertions for
stop() and showStatus() to ensure all three call sites exist; reference
sandboxEnvPrefix() and start(), stop(), showStatus() to locate the relevant
checks in the test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
nemoclaw startlaunches the Telegram bridge correctly, butnemoclaw statusreports it as stopped andnemoclaw stopsays it's not running (even though the process is alive).Root Cause
In
bin/nemoclaw.js:start()resolves the sandbox name from the registry and passesSANDBOX_NAME=<name>tostart-services.sh, which saves the PID file in/tmp/nemoclaw-services-<name>/.stop()calledstart-services.sh --stopwithout passingSANDBOX_NAME, so the shell script defaulted to"default"and looked in/tmp/nemoclaw-services-default/— a different directory.showStatus()had the same problem — noSANDBOX_NAMEpassed, so it always checked the wrong PID directory.This meant the PID file written by
startwas invisible to bothstatusandstop.Fix
Extract a shared
sandboxEnvPrefix()helper that resolves the default sandbox name from the registry (same logicstart()already had), and use it in all three functions:start(),stop(), andshowStatus().Changes
bin/nemoclaw.js: ExtractsandboxEnvPrefix(), apply it tostop()andshowStatus()test/service-env.test.js: Add regression tests verifyingstop()andshowStatus()use the shared helper, preventing future driftTesting
All 189 existing tests pass (1 pre-existing unrelated failure in
install-preflight.test.js). 3 new regression tests added.Fixes #587
Summary by CodeRabbit
Refactor
Tests