Skip to content

fix: Check for git command existence in install_nemoclaw#562

Open
undervillain wants to merge 1 commit intoNVIDIA:mainfrom
undervillain:undervillain-check-git-exists
Open

fix: Check for git command existence in install_nemoclaw#562
undervillain wants to merge 1 commit intoNVIDIA:mainfrom
undervillain:undervillain-check-git-exists

Conversation

@undervillain
Copy link

@undervillain undervillain commented Mar 21, 2026

Summary

Ubuntu server 24.04.4 LTS minimal installation does not include git. The install script assumes git to exist (not entirely unreasonable) and terminates ungracefully:

Computing checksum with sha256sum
Checksums matched!
Now using node v22.22.1 (npm v10.9.4)
Creating default alias: default -> 22 (-> v22.22.1 *)
[INFO]  Node.js installed: v22.22.1
[INFO]  Runtime OK: Node.js v22.22.1, npm 10.9.4
[INFO]  Installing NemoClaw from GitHub…
main: line 281: git: command not found

Changes

  • Add a check to install_nemoclaw() to check for git. FUTURE: might be better to have a single prerequisites-check function. You can decide.

Type of Change

  • Code change for a new feature, bug fix, or refactor.
  • Code change with doc updates.
  • Doc only. Prose changes without code sample modifications.
  • Doc only. Includes code sample changes.

Testing

  • Ran the update on my system that was producing the error above. It now terminates gracefully.

Checklist

General

Code Changes

Not Applicable for this change

  • make format applied (TypeScript and Python).
  • Tests added or updated for new or changed behavior.
  • No secrets, API keys, or credentials committed.
  • Doc pages updated for any user-facing behavior changes (new commands, changed defaults, new features, bug fixes that contradict existing docs).

Doc Changes

Not Applicable for this change

  • Follows the style guide. Try running the update-docs agent skill to draft changes while complying with the style guide. For example, prompt your agent with "/update-docs catch up the docs for the new changes I made in this PR."
  • New pages include SPDX license header and frontmatter, if creating a new page.
  • Cross-references and links verified.

Summary by CodeRabbit

  • Bug Fixes
    • The installer now validates required dependencies before starting the installation process, ensuring clearer error messages when prerequisites are missing and preventing incomplete installations.

The install.sh scrip assumes git exists.  This isn't true on some minimal installation flavors (e.g. Ubuntu 24.04.4 LTS minimal).
@coderabbitai
Copy link

coderabbitai bot commented Mar 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 90623632-f8af-4142-b32a-9d3b5b0a1c9f

📥 Commits

Reviewing files that changed from the base of the PR and between be7ec09 and 4eeecfa.

📒 Files selected for processing (1)
  • install.sh

📝 Walkthrough

Walkthrough

The install_nemoclaw() function now includes an explicit prerequisite check that verifies git is available on the system PATH before proceeding with the GitHub cloning step. If git is not found, the installer terminates with an error message.

Changes

Cohort / File(s) Summary
Git Prerequisite Validation
install.sh
Added command_exists git check in install_nemoclaw() to fail early if git is missing, preventing downstream errors during GitHub cloning.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A git check before we clone,
No more silent stumbles alone!
One line added with care,
Dependencies declared right there! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding a check for git command existence in the install_nemoclaw function.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can enforce grammar and style rules using `languagetool`.

Configure the reviews.tools.languagetool setting to enable/disable rules and categories. Refer to the LanguageTool Community to learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant