fix: Check for git command existence in install_nemoclaw#562
fix: Check for git command existence in install_nemoclaw#562undervillain wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
The install.sh scrip assumes git exists. This isn't true on some minimal installation flavors (e.g. Ubuntu 24.04.4 LTS minimal).
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment Tip CodeRabbit can enforce grammar and style rules using `languagetool`.Configure the |
Summary
Ubuntu server 24.04.4 LTS minimal installation does not include git. The install script assumes git to exist (not entirely unreasonable) and terminates ungracefully:
Changes
Type of Change
Testing
Checklist
General
Code Changes
Not Applicable for this change
make formatapplied (TypeScript and Python).Doc Changes
Not Applicable for this change
update-docsagent skill to draft changes while complying with the style guide. For example, prompt your agent with "/update-docscatch up the docs for the new changes I made in this PR."Summary by CodeRabbit