Skip to content

[6.17]NVIDIA: VR: SAUCE: firmware: smccc: lfa: fix work item re-initialization race #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nirmoy wants to merge 1 commit into
base: 24.04_linux-nvidia-6.17-next
Choose a base branch
from
Open

[6.17]NVIDIA: VR: SAUCE: firmware: smccc: lfa: fix work item re-initialization race #343

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions drivers/firmware/smccc/lfa_fw.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,7 +653,6 @@ static int update_fw_images_tree(void)
* _store() handler, so have to postpone the list removal to a
* workqueue.
*/
INIT_WORK(&fw_images_update_work, remove_invalid_fw_images);
queue_work(fw_images_update_wq, &fw_images_update_work);

return 0;
Expand All @@ -680,7 +679,7 @@ static void lfa_notify_handler(acpi_handle handle, u32 event, void *data)
* of all activable and pending images.
*/
do {
/* Reset activable image flag */
flush_workqueue(fw_images_update_wq);
found_activable_image = false;
list_for_each_entry(attrs, &lfa_fw_images, image_node) {
if (attrs->fw_seq_id == -1)
Expand Down Expand Up @@ -782,6 +781,8 @@ static int __init lfa_init(void)
return -ENOMEM;
}

INIT_WORK(&fw_images_update_work, remove_invalid_fw_images);

pr_info("Live Firmware Activation: detected v%ld.%ld\n",
reg.a0 >> 16, reg.a0 & 0xffff);

Expand Down