[linux-nvidia-6.17] Backport GPIO line name prefix handling#340
Open
nvmochs wants to merge 2 commits intoNVIDIA:24.04_linux-nvidia-6.17-nextfrom
Open
[linux-nvidia-6.17] Backport GPIO line name prefix handling#340nvmochs wants to merge 2 commits intoNVIDIA:24.04_linux-nvidia-6.17-nextfrom
nvmochs wants to merge 2 commits intoNVIDIA:24.04_linux-nvidia-6.17-nextfrom
Conversation
added 2 commits
March 11, 2026 14:22
Introduce TEGRA_GPIO_PREFIX() to define the Tegra SoC GPIO name prefix in one place. Use it for the Tegra410 COMPUTE and SYSTEM controllers so the prefix is "COMPUTE-" and "SYSTEM-" respectively. Signed-off-by: Prathamesh Shete <pshete@nvidia.com> Acked-by: Thierry Reding <treding@nvidia.com> Reviewed-by: Jon Hunter <jonathanh@nvidia.com> Link: https://patch.msgid.link/20260217081431.1208351-1-pshete@nvidia.com Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com> (cherry picked from commit 2423e336d94868f0d2fcd81a87b90c5ea59736e0 linux-next) Signed-off-by: Matthew R. Ochs <mochs@nvidia.com>
On Tegra platforms, multiple SoC instances may be present with each defining the same GPIO name. For such devices, this results in duplicate GPIO names. When the device has a valid NUMA node, prepend the NUMA node ID to the GPIO name prefix. The node ID identifies each socket, ensuring GPIO line names remain distinct across multiple sockets. Signed-off-by: Prathamesh Shete <pshete@nvidia.com> Acked-by: Thierry Reding <treding@nvidia.com> Reviewed-by: Jon Hunter <jonathanh@nvidia.com> Link: https://patch.msgid.link/20260217081431.1208351-2-pshete@nvidia.com Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com> (cherry picked from commit 2c299030c6813eaa9ef95773c64d65c50fa706ac linux-next) Signed-off-by: Matthew R. Ochs <mochs@nvidia.com>
clsotog
approved these changes
Mar 11, 2026
Collaborator
clsotog
left a comment
There was a problem hiding this comment.
Acked-by: Carol L Soto <csoto@nvidia.com>
Collaborator
|
|
jamieNguyenNVIDIA
approved these changes
Mar 12, 2026
Collaborator
Author
|
PR submitted to Canonical. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These two upstream patches (currently in linux-next, ETA v7.1) add support for GPIO devices on multi-socket systems and are required for VR. Without these patches, there are duplicate gpio names and the kernel logs warnings during boot:
With the patches in place on a system that defines ACPI PXM nodes for the GPIO devices, gpio names include the corresponding NUMA node:
This removes the collisions warnings during boot:
LKML: https://lore.kernel.org/all/20260217081431.1208351-1-pshete@nvidia.com/
linux-next:
To test, I verified the presence of the PXM nodes:
And the removal of the duplicate gpio names and collision warnings (included above).
Note that this requires UEFI support added in nvb5277588.
LP: https://bugs.launchpad.net/ubuntu/+source/linux-nvidia-6.17/+bug/2143954