Skip to content

RO-3182: Erstatt istykkelse-plott med lenke til iskart#970

Merged
jorgkv merged 6 commits intodevelopfrom
feature/RO-3182-iskart-link
Apr 9, 2026
Merged

RO-3182: Erstatt istykkelse-plott med lenke til iskart#970
jorgkv merged 6 commits intodevelopfrom
feature/RO-3182-iskart-link

Conversation

@jorgkv
Copy link
Copy Markdown
Contributor

@jorgkv jorgkv commented Apr 8, 2026

  • Fjerner istykkelse-plott
  • Legger til lenke til iskart, for å se istykkelse der
  • Legger også til lenke til iskart for å gå til samme kartutsnitt der

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-970.westeurope.azurestaticapps.net

1 similar comment
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-970.westeurope.azurestaticapps.net

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-970.westeurope.azurestaticapps.net

@jorgkv jorgkv requested a review from Copilot April 9, 2026 10:54
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-970.westeurope.azurestaticapps.net

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the embedded ice-thickness plot integration and replaces it with links to iskart.no for viewing ice thickness/layering and for opening the same map extent.

Changes:

  • Removed plot.regobs.no configuration and deleted the Plot/IcePlot implementation.
  • Added iskart.no links in the observation details UI (map extent + ice thickness context link).
  • Updated IceThicknessViewComponent inputs to build an iskart.no URL from ObsLocationID and observation date.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/settings.ts Removes plotUrl service configuration.
src/assets/i18n/nb.json Adds new ISKART.* translation keys (Norwegian).
src/assets/i18n/en.json Adds new ISKART.* translation keys (English).
src/app/pages/view-observation/view-observation.page.ts Adds computed iskartUrl for ice observations; removes PlotService usage.
src/app/pages/view-observation/view-observation.page.scss Adds styling for the new iskart link block.
src/app/pages/view-observation/view-observation.page.html Renders new iskart link; updates ice thickness component bindings.
src/app/core/services/plot.service.ts Deleted (no longer needed).
src/app/components/observation/registrations/ice-thickness-view/ice-thickness-view.component.ts Replaces plot URL logic with iskart URL logic; new inputs.
src/app/components/observation/registrations/ice-thickness-view/ice-thickness-view.component.html Replaces plot UI with iskart link + summary.
src/app/components/observation/registrations/ice-thickness-view/ice-thickness-view.component.css Removes prior host layout styling.
src/app/components/observation/observation/observation.component.html Updates ice thickness view bindings (but still includes a stale regId binding).
src/app/components/observation/graphics/ice-plot.component.ts Deleted (no longer needed).

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-970.westeurope.azurestaticapps.net

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-970.westeurope.azurestaticapps.net

@jorgkv jorgkv merged commit 5e7861d into develop Apr 9, 2026
8 checks passed
@jorgkv jorgkv deleted the feature/RO-3182-iskart-link branch April 9, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants