RO-3182: Erstatt istykkelse-plott med lenke til iskart#970
Conversation
jorgkv
commented
Apr 8, 2026
- Fjerner istykkelse-plott
- Legger til lenke til iskart, for å se istykkelse der
- Legger også til lenke til iskart for å gå til samme kartutsnitt der
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-970.westeurope.azurestaticapps.net |
1 similar comment
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-970.westeurope.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-970.westeurope.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-970.westeurope.azurestaticapps.net |
There was a problem hiding this comment.
Pull request overview
This PR removes the embedded ice-thickness plot integration and replaces it with links to iskart.no for viewing ice thickness/layering and for opening the same map extent.
Changes:
- Removed
plot.regobs.noconfiguration and deleted the Plot/IcePlot implementation. - Added iskart.no links in the observation details UI (map extent + ice thickness context link).
- Updated
IceThicknessViewComponentinputs to build an iskart.no URL fromObsLocationIDand observation date.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/settings.ts | Removes plotUrl service configuration. |
| src/assets/i18n/nb.json | Adds new ISKART.* translation keys (Norwegian). |
| src/assets/i18n/en.json | Adds new ISKART.* translation keys (English). |
| src/app/pages/view-observation/view-observation.page.ts | Adds computed iskartUrl for ice observations; removes PlotService usage. |
| src/app/pages/view-observation/view-observation.page.scss | Adds styling for the new iskart link block. |
| src/app/pages/view-observation/view-observation.page.html | Renders new iskart link; updates ice thickness component bindings. |
| src/app/core/services/plot.service.ts | Deleted (no longer needed). |
| src/app/components/observation/registrations/ice-thickness-view/ice-thickness-view.component.ts | Replaces plot URL logic with iskart URL logic; new inputs. |
| src/app/components/observation/registrations/ice-thickness-view/ice-thickness-view.component.html | Replaces plot UI with iskart link + summary. |
| src/app/components/observation/registrations/ice-thickness-view/ice-thickness-view.component.css | Removes prior host layout styling. |
| src/app/components/observation/observation/observation.component.html | Updates ice thickness view bindings (but still includes a stale regId binding). |
| src/app/components/observation/graphics/ice-plot.component.ts | Deleted (no longer needed). |
src/app/components/observation/observation/observation.component.html
Outdated
Show resolved
Hide resolved
...pp/components/observation/registrations/ice-thickness-view/ice-thickness-view.component.html
Show resolved
Hide resolved
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-970.westeurope.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-970.westeurope.azurestaticapps.net |