Few simple changes to allow code to cleanly compile on Linux/MacOS/Windows (VS2019/22) - add github action to do builds / add unit tests#11
Conversation
alastairUK
changed the title
|
I don't believe this should have been closed, so I'm reopening it for a later time. |
wkozmaNTIA
left a comment
wkozmaNTIA
left a comment
There was a problem hiding this comment.
I have 1 comment for you to respond to. Also, I will probably merge this but remove the github actions file for the time being. You can resubmit that as a new pull request, but not ready for that at the moment. Want to update the Linux support and the couple other code quality items you suggest.
| | | ||
| *===========================================================================*/ | ||
| void Troposcatter(Path *path, Terminal *terminal_1, Terminal *terminal_2, double d__km, double f__mhz, TroposcatterParams *tropo) | ||
| void Troposcatter(Path * /*path*/, Terminal *terminal_1, Terminal *terminal_2, double d__km, double f__mhz, TroposcatterParams *tropo) |
There was a problem hiding this comment.
I'm not sure I understand what you are doing here?
|
Even though I approved this request, @alastairUK if you could respond to the above question that would be appreciated. I'm holding off merging for a bit to give you a chance to respond |
alastairUK
force-pushed
the
NewVersion
branch
2 times, most recently
from
7539d14 to
06fed75
Compare
…and ‘std::vector<int>::size_type’ {aka ‘long unsigned int’} [-Werror=sign-compare]
|
I was compiling with these options
So warning are errors. Without that change you get...
I have rebased this PR onto cmake-support branch and fixed a couple more things Note the github action compiles cleanly https://github.com/alastairUK/p528/runs/6864839884
|
alastairUK
changed the title
3 participants
Some simple changes to automatically build on Window/Linux/Mac OS using GitHub actions. Have upped the warning level to W4 and fixed a few issues. Also added a very simple set of unit tests.
One thing my linter is picking up is the use of reserved identifiers (basically __)
https://clang.llvm.org/extra/clang-tidy/checks/bugprone-reserved-identifier.html
This is obviously all over the code as it's part of your coding standard. But something to be aware of I guess.