Skip to content

[routes/chlorides] Add additional NULL Guards to report endpoint #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TylerAdamMartinez merged 1 commit into from
Sep 19, 2025
Merged

[routes/chlorides] Add additional NULL Guards to report endpoint #139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions api/routes/chlorides.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,9 +174,13 @@ def get_chlorides_report(
se_rows = [
(val, lat, lon)
for (val, lat, lon) in rows
if (lat is not None and lon is not None
if (
val is not None
and lat is not None
and lon is not None
and SE_MIN_LAT <= float(lat) <= SE_MAX_LAT
and SE_MIN_LON <= float(lon) <= SE_MAX_LON)
and SE_MIN_LON <= float(lon) <= SE_MAX_LON
)
]

north_vals: List[float] = []
Expand All @@ -185,6 +189,9 @@ def get_chlorides_report(
west_vals: List[float] = []

for val, lat, lon in se_rows:
if val is None:
continue # skip null chloride values

# North vs South halves within the SE quadrant
if float(lat) >= SE_MID_LAT:
north_vals.append(float(val))
Expand Down