Mdeshotel 9712 forcing input mod2

Forcing_Extraction_Scripts/forecast_download_base.py

@@ -5,19 +5,15 @@
 import time
 import uuid
 from abc import ABC, abstractmethod
-from datetime import datetime, timezone, timedelta
-from urllib import request, error
+from datetime import datetime, timedelta, timezone
+from urllib import error, request
 
+# Use the Error, Warning, and Trapping System Package for logging
+import ewts
 import requests
 from bs4 import BeautifulSoup
 
-from nextgen_forcings_ewts import MODULE_NAME
-
-LOG = logging.getLogger(MODULE_NAME)
-if not LOG.handlers:
-    # No handlers attached — fallback to default root logger
-    logging.basicConfig()
-    LOG = logging.getLogger()
+LOG = ewts.get_logger(ewts.FORCING_ID)
 
 
 class ForecastDownloader(ABC):
@@ -40,7 +36,15 @@ class ForecastDownloader(ABC):
     default_cleanback = 240
     default_lagback = 6
 
-    def __init__(self, out_dir, start_time, lookback_hours, cleanback_hours, lagback_hours, ens_number):
+    def __init__(
+        self,
+        out_dir,
+        start_time,
+        lookback_hours,
+        cleanback_hours,
+        lagback_hours,
+        ens_number,
+    ):
         """
         Initialize downloader with common configuration.
 
@@ -50,6 +54,15 @@ def __init__(self, out_dir, start_time, lookback_hours, cleanback_hours, lagback
         :param cleanback_hours: How far back to clean old files
         :param lagback_hours: How many hours to lag before starting to fetch
         """
+        global LOG
+        if hasattr(LOG, "bind"):
+            # This is required prior to the first log message for the ewts package
+            LOG.bind()
+        else:
+            # Fallback to default root logger
+            logging.basicConfig()
+            LOG = logging.getLogger()
+
         if lookback_hours <= lagback_hours:
             raise ValueError(
                 f"Invalid configuration: lookback_hours ({lookback_hours}) must be greater than "
@@ -64,7 +77,9 @@ def __init__(self, out_dir, start_time, lookback_hours, cleanback_hours, lagback
         self.ens_number = ens_number
 
         # Current hour, rounded to the top of the hour in UTC
-        self.d_now = datetime.now(timezone.utc).replace(minute=0, second=0, microsecond=0)
+        self.d_now = datetime.now(timezone.utc).replace(
+            minute=0, second=0, microsecond=0
+        )
 
         # Format ens_number
         self.ens_number = str(self.ens_number).zfill(2)
@@ -100,12 +115,14 @@ def from_cli_args(cls):
         Also prints the parsed arguments for logging/debugging.
         """
         parser = argparse.ArgumentParser()
-        parser.add_argument('outDir', type=str, help="Output directory path")
-        parser.add_argument('startTime', type=lambda s: datetime.strptime(s, "%Y-%m-%d %H:%M:%S"))
-        parser.add_argument('--lookBackHours', type=int, default=cls.default_lookback)
-        parser.add_argument('--cleanBackHours', type=int, default=cls.default_cleanback)
-        parser.add_argument('--lagBackHours', type=int, default=cls.default_lagback)
-        parser.add_argument('--ensNumber', type=int, default=None)
+        parser.add_argument("outDir", type=str, help="Output directory path")
+        parser.add_argument(
+            "startTime", type=lambda s: datetime.strptime(s, "%Y-%m-%d %H:%M:%S")
+        )
+        parser.add_argument("--lookBackHours", type=int, default=cls.default_lookback)
+        parser.add_argument("--cleanBackHours", type=int, default=cls.default_cleanback)
+        parser.add_argument("--lagBackHours", type=int, default=cls.default_lagback)
+        parser.add_argument("--ensNumber", type=int, default=None)
         args = parser.parse_args()
 
         print(f"{cls.__name__} args:", vars(args))
@@ -116,7 +133,7 @@ def from_cli_args(cls):
             lookback_hours=args.lookBackHours,
             cleanback_hours=args.cleanBackHours,
             lagback_hours=args.lagBackHours,
-            ens_number=args.ensNumber
+            ens_number=args.ensNumber,
         )
 
     def run(self):
@@ -254,7 +271,9 @@ def _download_data(self):
         Download forecast files by iterating over the desired time range and download targets.
         Each timestamp may have one or more targets to process.
         """
-        LOG.info(f"ForecastDownloader: Download data. lookback: {self.lookback_hours} lagback: {self.effective_lagback()}")
+        LOG.info(
+            f"ForecastDownloader: Download data. lookback: {self.lookback_hours} lagback: {self.effective_lagback()}"
+        )
         for hour in range(self.lookback_hours, self.effective_lagback(), -1):
             d_start = self.start_time - timedelta(hours=hour)
 
@@ -271,7 +290,9 @@ def _download_data(self):
 
             targets = self.get_download_targets(d_start)
             for target in targets:
-                url, filename = self.build_file_url_and_name(d_start, target, self.ens_number)
+                url, filename = self.build_file_url_and_name(
+                    d_start, target, self.ens_number
+                )
                 out_path = os.path.join(output_dir, filename)
 
                 LOG.info(f"Looking for file {out_path}")
@@ -341,7 +362,9 @@ def _download_file(self, url, out_path):
 
                 except FileExistsError:
                     # Another process already published the file.
-                    LOG.info(f"{out_path} already exists; another process wrote it first. Removing temp.")
+                    LOG.info(
+                        f"{out_path} already exists; another process wrote it first. Removing temp."
+                    )
                     os.remove(temp_path)
                     return
 
@@ -402,7 +425,9 @@ def get_file_specs(self, d_start) -> list[tuple[str, str]]:
         pass
 
     def _download_data(self):
-        LOG.info(f"FixedFileDownloader: Download data. lookback: {self.lookback_hours} lagback: {self.effective_lagback()}")
+        LOG.info(
+            f"FixedFileDownloader: Download data. lookback: {self.lookback_hours} lagback: {self.effective_lagback()}"
+        )
         for hour in range(self.lookback_hours, self.effective_lagback(), -1):
             d_start = self.start_time - timedelta(hours=hour)
 
@@ -450,10 +475,14 @@ def get_download_targets(self, _):
         return [0]  # Satisfy the abstract method; not used for scraping
 
     def build_file_url_and_name(self, d_start, target):
-        raise NotImplementedError("ScrapedFileDownloader uses scraping logic instead of build_file_url_and_name().")
+        raise NotImplementedError(
+            "ScrapedFileDownloader uses scraping logic instead of build_file_url_and_name()."
+        )
 
     def _download_data(self):
-        LOG.info(f"ScrapedFileDownloader: Download data. lookback: {self.lookback_hours} lagback: {self.effective_lagback()}")
+        LOG.info(
+            f"ScrapedFileDownloader: Download data. lookback: {self.lookback_hours} lagback: {self.effective_lagback()}"
+        )
         for hour in range(self.lookback_hours, self.effective_lagback(), -1):
             d_start = self.start_time - timedelta(hours=hour)
 

NextGen_Forcings_Engine_BMI/NextGen_Forcings_Engine/bmi_grid.py

@@ -13,11 +13,11 @@
 
 if TYPE_CHECKING:
     from numpy.typing import NDArray
-import logging
 
-from nextgen_forcings_ewts import MODULE_NAME
+# Use the Error, Warning, and Trapping System Package for logging
+import ewts
 
-LOG = logging.getLogger(MODULE_NAME)
+LOG = ewts.get_logger(ewts.FORCING_ID)
 
 _error_on_grid_type: bool = False